patchmldonkey, a multi-networks file-sharing client - Patches: patch #4909, Add os_supported () print several...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4909: Add os_supported () print several warnings for not supported operating systems

Submitter:  Schlumpf <schlumpf_>
Submitted:  Sun 12 Feb 2006 06:50:06 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Mon 20 Feb 2006 01:17:58 AM UTC, comment #6: 

Applied 4909.patch 2006/02/20

spiralvoice <spiralvoice>
Group administrator
Sat 18 Feb 2006 06:48:27 PM UTC, comment #5: 

@zet
i follow your suggestions and be hopeful that the attached patch is the final version ;)

>> I also don't think it should 'exit'

i don`t think so, because any kind of software should exit on start if the operating system is not supported to let them run on it without any trouble.
But for the time being i only issue several warnings.

Schlumpf <schlumpf_>
Group Member
Fri 17 Feb 2006 10:45:00 PM UTC, comment #4: 

I doubt that will compile on anything other than windows.

Windows specific calls go in src/config/mingw/os_stubs_c.c

I think you should have a general os_supported() function.  In src/config/unix/os_stubs_c.c it just returns true.  On windows it checks for NT.

If it fails, issue a warning. I don't think anything needs to be windows specific about this in mldonkey.  I also don't think it should 'exit'.  If someone wants to run mldonkey, why stop them? Just warn them that it isn't a supported platform.

z <zet>
Group Member
Fri 17 Feb 2006 09:59:40 PM UTC, comment #3: 

@zet
2. new Patch attached, hope it is now a better solution
3. canceled
4. see patch

@spiralvoice
this patch depends on patch #4918

Schlumpf <schlumpf_>
Group Member
Mon 13 Feb 2006 08:54:24 PM UTC, comment #2: 

@zet:
4. <- done
3. The output of "used OS" is useless in production version, users know which OS they have, and if they do not know, they do not care.
2. <- agreed
1. From ocaml/README.win32
=============================================================
           The native Win32 port built with Mingw
           --------------------------------------
REQUIREMENTS:
This port runs under MS Windows NT, 2000 and XP.
Windows 95, 98 and ME are also supported, but less reliably.
=============================================================
So its not really known if MLDonkey will work on Win9x/ME but
because of their limited TCP/IP stack, using it there makes no fun.

spiralvoice <spiralvoice>
Group administrator
Sun 12 Feb 2006 07:43:23 PM UTC, comment #1: 

1. What is the point of disabling these OSs?  If it works for someone on these OSs, why not let them use it?  A warning seems more appropriate, unless you are absolutely sure that it does not work.

2. Matching arbitrary strings is always wrong in code when there is a perfectly standard way to do what you are trying to do. (especially when some strings have spaces after them and some don't). Use the windows API properly: the dwPlatformId field of OSVERSIONINFO is all you need if you really want to identifty non NT based systems.

3. Why do only windows users get this "used OS" line at startup?  Mldonkey should try to be consistent on all platforms.

4. "unknown Operating System, please report Mldonkey Dev Team"

"Unknown operating system, please report to the MLDonkey development team at http://..."

- it is better to give people a method to use to file reports when you request that they send information.

z <zet>
Group Member
Sun 12 Feb 2006 06:50:06 PM UTC, original submission:  


Schlumpf <schlumpf_>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9585:  4909.patch added by spiralvoice (6KiB - application/octet-stream - small changes to log output)
file #9583:  os_supported2.patch added by schlumpf_ (6KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 11 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-02-20 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2006-02-20 spiralvoice Attached File- Added 4909.patch, #5965
2006-02-19 spiralvoice Attached File#5955 Removed
2006-02-18 schlumpf_ Attached File- Added os_supported2.patch, #5956
2006-02-18 spiralvoice Summarylet fail start on Windows 9x/ME Add os_supported () print several warnings for not supported operating systems
2006-02-18 spiralvoice Attached File#5951 Removed
2006-02-18 spiralvoice Attached File#5933 Removed
2006-02-18 schlumpf_ Attached File- Added os_supported.patch, #5955
2006-02-17 schlumpf_ Attached File- Added win_nt.patch, #5951
2006-02-12 schlumpf_ Attached File- Added win9x_me.patch, #5933

Back to the top

Powered by Savane 3.13-bb6a.
Corresponding source code