Updated 4976_3.patch
- Magic values for BT sub_files (displayed in vd #num) and shared files (displayed in upstats, js popup) are now also computed
- Storing magic value strings happens now in a weak hashtable to save RAM (see mem_stats CommonFile, files_magic:)

added another version of this patch, using Ocaml-Magic bindings
from http://sourceforge.net/projects/ocaml-magic

• new value impl_file_magic in CommonFile structure (Todo: GUI protocol)
• to read CommonFile.file_magic file
• CommonFile magic values are computed once a minute for files without it
• new debug command: debug_dir, prints magic values for all files

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client task tracker to your tracker.

The original report is still available at task #5324

Following are the information included in the original report:

[field #0]                  Item ID: 5324
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #6]                 Category: None
[field #7]             Submitted by: jave
[field #8]              Assigned to: None
[field #9]             Submitted on: Mi 15.03.2006 um 21:55
[field #10]                  Summary: filetype recognition with libmagic
[field #11]      Original Submission: It would be desirable to know the real filetype of a downloading file as soon as possible. The filetype given by libmagic can then be compared with the file extension. If they differ, say a "rar" is reaaly an "avi", the file is probably a fake.

Libmagic, which is used in the unix "file" command can be used for this.

There didnt seem to be any mainatined libmagic wrappers for ocaml, so I tried generating them with swig. It worked fairly well.

See attached file with the experiment.

This should of course be a configure-time option.


[field #13]               Item Group: None
[field #14]                   Status: None
[field #15]        Component Version: None
[field #16]         Platform Version: None
[field #17]          Reproducibility: None
[field #18]               Size (loc): None
[field #19]            Fixed Release: None
[field #20]          Planned Release: None
[field #21]                   Effort: 0.00
[field #25]                 Priority: 1 - Later
[field #26]          Should Start On: Mi 15.03.2006 um 01:00
[field #27]    Should be Finished on: Mi 15.03.2006 um 01:00
[field #28]         Percent Complete: 0%
[field #30]                  Release: None
[field #55]     Custom Select Box #1: None
[field #56]     Custom Select Box #2: None
[field #57]     Custom Select Box #3: None
[field #58]     Custom Select Box #4: None
[field #59]     Custom Select Box #5: None
[field #60]     Custom Select Box #6: None
[field #61]     Custom Select Box #7: None
[field #62]     Custom Select Box #8: None
[field #63]     Custom Select Box #9: None
[field #64]    Custom Select Box #10: None

For later usage: libmagic requires (among other stuff) GNU regex
for compiling on MinGW, here is how to do it:
http://www.openldap.org/faq/data/cache/302.html#2
ftp://ftp.gnu.org/gnu/regex

        $ ./configure --prefix=/mingw i686-pc-mingw32
        $ make subdirs= (ignore the error message)
        $ ar ru libregex.a regex.o
        $ cp regex.h /mingw/include
        $ cp libregex.a /mingw/lib

Attached a dirty hack for MLDonkey, no configure checking atm.
But libmagic function should be usable from inside MLDonkey now.

It would be desirable to know the real filetype of a downloading file as soon as possible. The filetype given by libmagic can then be compared with the file extension. If they differ, say a "rar" is reaaly an "avi", the file is probably a fake.

Libmagic, which is used in the unix "file" command can be used for this.

There didnt seem to be any mainatined libmagic wrappers for ocaml, so I tried generating them with swig. It worked fairly well.

See attached file with the experiment.

This should of course be a configure-time option.