patchmldonkey, a multi-networks file-sharing client - Patches: patch #5015, Fix option file saving bug...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5015: Fix option file saving bug introduced in tryopen patch

Submitter:  spiralvoice <spiralvoice>
Submitted:  Wed 05 Apr 2006 12:15:14 AM UTC
   
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Wed 05 Apr 2006 07:02:30 AM UTC, comment #2: 

If that patch is necessary, that means that

Sys.rename filename old_file

silently fails. I think it hides a bug rather than fix it.
Could the "try ... with" construct be instrumented to log the exception rather than just discard it, and be tried again on the platform that triggers the problem ?

pango <mlpango>
Group Member
Wed 05 Apr 2006 12:16:56 AM UTC, comment #1: 

Applied 2006/04/05

spiralvoice <spiralvoice>
Group administrator
Wed 05 Apr 2006 12:15:14 AM UTC, original submission:  

All ini files were saved as .ini.tmp but not renamed to .ini

spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9715:  tryopen_fix.patch added by spiralvoice (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-04-05 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2006-04-05 spiralvoice Attached File- Added tryopen_fix.patch, #9715

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code