patchmldonkey, a multi-networks file-sharing client - Patches: patch #5124, Log: Login messages can be...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5124: Log: Login messages can be disabled with verbosity "no-login"

Submitter:  spiralvoice <spiralvoice>
Submitted:  Wed 24 May 2006 10:18:46 AM UTC
   
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Thu 25 May 2006 08:02:47 PM UTC, comment #9: 

Nice solution for every one.

atordo <atordo>
Thu 25 May 2006 07:52:23 PM UTC, comment #8: 

Applied 2006/05/25

spiralvoice <spiralvoice>
Group administrator
Thu 25 May 2006 04:33:30 PM UTC, comment #7: 

Looks fine to me.

z <zet>
Group Member
Thu 25 May 2006 04:19:54 PM UTC, comment #6: 

Updated patch, "set verbosity no-login" disables all login messages. Ok to apply?

spiralvoice <spiralvoice>
Group administrator
Thu 25 May 2006 01:52:06 PM UTC, comment #5: 

There is nothing wrong with being able to explicitly disable it.  The comment clearly says that it should be on by default.  A non-default setting to disable it is fine. "set verbosity no-login"

z <zet>
Group Member
Thu 25 May 2006 09:29:43 AM UTC, comment #4: 

If login every access is so fundamental, I fail to see how mldonkey users have survived without it for years. I can see how it is useful, but it should be some way to disable it. Otherwise, the use of Web-GMUI or any other front end which interacts with telnet interface renders the log unreadable and absurdly long.

atordo <atordo>
Wed 24 May 2006 02:52:45 PM UTC, comment #3: 

The issue for me is security.

The concept is that there should be a log of who accesses the server for each and every access, and that this log exists at the default log level.  It will point out bad users, attempted floods, just like a normal pam or sshd log.  If a user has to specifically turn on this log level, well, it could already be too late for them to figure out who did what bad thing on their server.

z <zet>
Group Member
Wed 24 May 2006 02:33:51 PM UTC, comment #2: 

http://mldonkey.sourceforge.net/forums/viewtopic.php?t=4234
What about a new verbosity kind "user_login"?

spiralvoice <spiralvoice>
Group administrator
Wed 24 May 2006 01:57:58 PM UTC, comment #1: 

Why is this needed?  I do not want to turn on any verbosity to be able to see something so fundamental.

z <zet>
Group Member
Wed 24 May 2006 10:18:46 AM UTC, original submission:  


spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10050:  5124.patch added by spiralvoice (5KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-05-25 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
    SummaryLog: Telnet login logging only for verbosity &quot;verb&quot; Log: Login messages can be disabled with verbosity "no-login"
2006-05-25 spiralvoice Attached File- Added 5124.patch, #10050
2006-05-25 spiralvoice Attached File#10040 Removed
2006-05-24 spiralvoice Attached File- Added login_log.patch, #10040

Back to the top

Powered by Savane 3.13-aa77.
Corresponding source code