patchmldonkey, a multi-networks file-sharing client - Patches: patch #5199, BT: Fix BT_client_uid changing...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5199: BT: Fix BT_client_uid changing between core start

Submitter:  orbit <orbit>
Submitted:  Thu 22 Jun 2006 07:32:02 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Thu 22 Jun 2006 07:34:11 PM UTC, comment #3: 

Applied 2006/06/22

spiralvoice <spiralvoice>
Group administrator
Thu 22 Jun 2006 07:32:02 PM UTC, comment #2: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #16887

Following are the information included in the original report:

[field #0]                  Item ID: 16887
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #6]                 Category: Bittorrent-Plugin
[field #7]             Submitted by: orbit
[field #8]              Assigned to: None
[field #9]             Submitted on: Dienstag 20.06.2006 um 00:09
[field #10]                  Summary: BT: BT_client_uid changes between two starts
[field #11]      Original Submission: BT_client_uid should only change when version changes

reproducing this is quite easy:

  • start mldonkey, note BT_client_uid
  • stop mldonkey
  • start mldonkey, compare the two uid s

-> change after the 14. character of the uid
e.g.:
FVGUYMROG4XDOLNUCIPKSKFNECUTCK4X
FVGUYMROG4XDOLJVYJVXMXABQQTXBUDR
[field #13]               Item Group: Program malfunction
[field #14]                   Status: None
[field #15]        Component Version: None
[field #16]         Operating System: None
[field #17]          Reproducibility: None
[field #18]               Size (loc): None
[field #19]            Fixed Release: None
[field #20]          Planned Release: None
[field #21]                   Effort: 0.00
[field #25]                 Priority: 5 - Normal
[field #28]         Percent Complete: 0%
[field #30]                  Release: 2.7.7
[field #31]                  Release: 2.7.7
[field #55]          Binaries Origin: CVS / Self compiled
[field #56]                 CPU type: None
[field #57]                      CPU: None
[field #58]     Custom Select Box #4: None
[field #59]     Custom Select Box #5: None
[field #60]     Custom Select Box #6: None
[field #61]     Custom Select Box #7: None
[field #62]     Custom Select Box #8: None
[field #63]     Custom Select Box #9: None
[field #64]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Wed 21 Jun 2006 11:31:25 PM UTC, comment #1: 


> if Autoconf.current_version != String.sub s 3 ((
>    try
>      String.index_from s 1 s.[0]
>    with
>      Not_found -> 3
>    ) - 3)


is always true
<> instead of != helps

patch attached, now BT_client_uid only changes if version changed

Whats the difference?
 <>  |Structural inequality test
 !=  |Physical inequality test

orbit <orbit>
Thu 22 Jun 2006 07:32:02 PM UTC, original submission:  

BT_client_uid should only change when version changes

reproducing this is quite easy:

  • start mldonkey, note BT_client_uid
  • stop mldonkey
  • start mldonkey, compare the two uid's

-> change after the 14. character of the uid
e.g.:
FVGUYMROG4XDOLNUCIPKSKFNECUTCK4X
FVGUYMROG4XDOLJVYJVXMXABQQTXBUDR

orbit <orbit>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10234:  bt-uid.patch added by orbit (708B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-06-22 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2006-06-22 spiralvoice SummaryReassigned item: BT: BT_client_uid changes between two starts BT: Fix BT_client_uid changing between core start
2006-06-22 spiralvoice Reassign itemFrom group mldonkey, a multi-networks file-sharing client, bugs tracker To group mldonkey, a multi-networks file-sharing client, patch tracker

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code