patchmldonkey, a multi-networks file-sharing client - Patches: patch #5238, Fix HDD space checks on CFS mounts

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5238: Fix HDD space checks on CFS mounts

Submitter:  Samuel Mimram <smimram>
Submitted:  Fri 14 Jul 2006 09:57:09 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Fri 14 Jul 2006 01:18:10 PM UTC, comment #5: 

Applied to CVS 2006/07/14

spiralvoice <spiralvoice>
Group administrator
Fri 14 Jul 2006 09:57:09 AM UTC, comment #4: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #17085

Following are the information included in the original report:

[field #0]                  Item ID: 17085
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #6]                 Category: Core
[field #7]             Submitted by: smimram
[field #8]              Assigned to: None
[field #9]             Submitted on: Dienstag 11.07.2006 um 21:14
[field #10]                  Summary: Fix HDD space checks on CFS mounts
[field #11]      Original Submission: Hi,

With the last upstream update, checks for minimum free space in the
core/temp directory were introduced. These checks use hard-coded minimum values and they cannot be switched off.

This causes mldonkey-server to refuse to run on filesystems which do not report the free space correctly, e.g. the cryptographic filesystem CFS.

Surely this is actually a bug in the filesystems, but mldonkey should be able to work around it by not enforcing min-free checks.

More info about the Debian bug report can be found at
http://bugs.debian.org/377865 />[field #13]               Item Group: Feature request
[field #14]                   Status: None
[field #15]        Component Version: None
[field #16]         Operating System: None
[field #17]          Reproducibility: None
[field #18]               Size (loc): None
[field #19]            Fixed Release: None
[field #20]          Planned Release: None
[field #21]                   Effort: 0.00
[field #25]                 Priority: 5 - Normal
[field #28]         Percent Complete: 0%
[field #30]                  Release: 2.7.7
[field #55]          Binaries Origin: Debian package
[field #56]                 CPU type: None
[field #57]                      CPU: None
[field #58]     Custom Select Box #4: None
[field #59]     Custom Select Box #5: None
[field #60]     Custom Select Box #6: None
[field #61]     Custom Select Box #7: None
[field #62]     Custom Select Box #8: None
[field #63]     Custom Select Box #9: None
[field #64]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Wed 12 Jul 2006 11:46:29 PM UTC, comment #3: 

Yes, I forgot the patch, here it is...
Please report if it fixes the bug, the patch can then go to CVS.

spiralvoice <spiralvoice>
Group administrator
Wed 12 Jul 2006 10:29:15 PM UTC, comment #2: 

Thanks a lot spiralvoice for your patch I'll integrate it in the Debian package. Apparently you forgot to attach the other patch, didn't you?

Samuel Mimram <smimram>
Wed 12 Jul 2006 04:44:55 PM UTC, comment #1: 

The hdd_space_check-patch has been introduced 2006/03/19,
this is the first bug report of this kind.
I set up a CFS partition here following
http://gentoo-wiki.com/HOWTO_Encrypt_Your_Home_Directory_Using_CFS#Introduction_to_CFS
and could reproduce the bug. Because of the sensitivity of
MLDonkeys ini file saving procedure IMHO its not a good idea
to create an option to disable DriverInteractive.hdd_check ().

Here is a patch which is a work-around for the CFS-freespace problem:

diff -a -x Root -x Repository -x Tag -x Entries -x Entries.Log -x .svn -x '*.rej' -x '*.orig' -N -r -u ./src/daemon/driver/driv
--- ./src/daemon/driver/driverInteractive.ml    2006-06-27 23:20:28.000000000 +0200
+++ ./src/daemon/driver/driverInteractive.ml    2006-07-12 18:39:02.000000000 +0200
@@ -93,6 +93,7 @@
   let dir_full dir mb =
     match Unix32.diskfree dir with
     | None -> false
+    | Some v when ((Unix32.filesystem dir = "NFS_SUPER_MAGIC") && v = zero) -> false
     | Some v -> v < megabytes mb
   in

CFS filesystems report themselves as NFS_SUPER_MAGIC, if the
freespace is reported as zero on such a partition its ignored
in the future during hdd_space_check. Attached you will find
a patch including the patch above + a cosmetic patch for
unix32 module to prevent a Division_by_zero error in debug_disk command.

spiralvoice <spiralvoice>
Group administrator
Fri 14 Jul 2006 09:57:09 AM UTC, original submission:  

Hi,

With the last upstream update, checks for minimum free space in the
core/temp directory were introduced. These checks use hard-coded minimum values and they cannot be switched off.

This causes mldonkey-server to refuse to run on filesystems which do not report the free space correctly, e.g. the cryptographic filesystem CFS.

Surely this is actually a bug in the filesystems, but mldonkey should be able to work around it by not enforcing min-free checks.

More info about the Debian bug report can be found at
http://bugs.debian.org/377865

Samuel Mimram <smimram>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10338:  cfs.patch added by spiralvoice (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by smimram
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2006-07-14 spiralvoice StatusNone Done
        Open/ClosedOpen Closed
        SummaryReassigned item: Fix HDD space checks on CFS mounts Fix HDD space checks on CFS mounts
    2006-07-14 spiralvoice Reassign itemFrom group mldonkey, a multi-networks file-sharing client, bugs tracker To group mldonkey, a multi-networks file-sharing client, patch tracker

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code