patchmldonkey, a multi-networks file-sharing client - Patches: patch #5253, Removed spaces at end of filename...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5253: Removed spaces at end of filename when committing to FAT partition, shorten filename to max_name_len of filesystem

Submitter:  Oleg <olegm>
Submitted:  Thu 20 Jul 2006 11:52:41 AM UTC
   
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Thu 20 Jul 2006 03:30:27 PM UTC, comment #6: 

Applied 2006/07/20

spiralvoice <spiralvoice>
Group administrator
Thu 20 Jul 2006 11:52:41 AM UTC, comment #5: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #15451

Following are the information included in the original report:

[field #0]                  Item ID: 15451
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 5 - Blocker
[field #4]                  Privacy: Public
[field #6]                 Category: Core
[field #7]             Submitted by: olegm
[field #8]              Assigned to: None
[field #9]             Submitted on: Sonntag 15.01.2006 um 17:04
[field #10]                  Summary: mldonkey fails to submit file with space at the end of filename
[field #11]      Original Submission: When mldonkey submits file with space at the end of filename, it logs following message:

2006/01/15 16:51:57 COPY ./temp/urn_ed2k_xxxxx TO ./incoming/xxxxx.avi
2006/01/15 16:51:57 [cInt] Exception in file_commit: Sys_error("./incoming/xxxxx.avi : No such file or directory")


The file appears in list of files to commit (although autocommit is set), but there seems to be no possibility to change file name.

Buildinfo:
MLNet Multi-Network p2p client version 2.7.2
Networks: Global Shares  Gnutella  G2  Fasttrack  FileTP  BitTorrent  Donkey
Ocaml version: 3.09.1
Build on: Linux i686 2.6.13-gentoo-r1 (little endian) with glibc 2.3.6
Configure arguments: --disable-gui
Features: threads zlib-1.2.3 bzip2-1.0.3 no-gd iconv no-check-bounds

Runinfo:
Enabled Networks:  Donkey BitTorrent FileTP
Server usage: enabled
System info: Linux olegm 2.6.13-gentoo-r1 #2 SMP Sat Sep 17 11:05:12 CEST 2005 i686
Uptime: 6h 4m 52s
Language: UK - locale: UTF-8 - UTC offset: +0100
 max_string_length: 16777211 - word_size: 32 - max_array_length: 4194303
 max file descriptors: 1024 - max useable file size: 2^63-1 bits (do the maths ;-p)
[field #13]               Item Group: Program malfunction
[field #14]                   Status: In Progress
[field #15]        Component Version: None
[field #16]         Operating System: Linux
[field #17]          Reproducibility: None
[field #18]               Size (loc): None
[field #19]            Fixed Release: None
[field #20]          Planned Release: None
[field #21]                   Effort: 0.00
[field #25]                 Priority: 5 - Normal
[field #28]         Percent Complete: 0%
[field #30]                  Release: 2.7.2
[field #55]          Binaries Origin: CVS / Self compiled
[field #56]                 CPU type: Intel x86
[field #57]                      CPU: None
[field #58]     Custom Select Box #4: None
[field #59]     Custom Select Box #5: None
[field #60]     Custom Select Box #6: None
[field #61]     Custom Select Box #7: None
[field #62]     Custom Select Box #8: None
[field #63]     Custom Select Box #9: None
[field #64]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Tue 27 Jun 2006 05:49:08 PM UTC, comment #4: 

Please try the attached patch.

spiralvoice <spiralvoice>
Group administrator
Sun 15 Jan 2006 09:13:37 PM UTC, comment #3: 

To get your file committed: stop MLDonkey, open files.ini, search for
the filename in the field file_filename and remove the space at the end.

This patch is part of 2.7.2:
4748: HTML: Allow rename of files with '#', '&' and '%',
      remove invalid chars from filenames depending on OS (thx to pango)

On FAT drives a space at the end of the filename is invalid, this
is the case on your system:

> ./incoming |shared (incoming_files) | 72.23G| 2.28G| 3%|msdos


The patch mentioned above currently checks filenames according to
the OS, this will be extended to FS specific checking to remove
a space at the end of a filename when its moved to a FAT partition.

spiralvoice <spiralvoice>
Group administrator
Sun 15 Jan 2006 08:48:58 PM UTC, comment #2: 

Directory    |Type                         |    used|    free|%free|Filesystem
-------------+-----------------------------+--------+--------+-----+----------
/2/ml        |core/ini files               |  30.93G|   3.25G|   9%|reiserfs
./temp       |temp/downloading             |  30.93G|   3.25G|   9%|reiserfs
./share      |shared (all_files)           |  72.23G|   2.28G|   3%|msdos
./bt_incoming|shared (incoming_directories)|  30.93G|   3.25G|   9%|reiserfs
./incoming   |shared (incoming_files)      |  72.23G|   2.28G|   3%|msdos

Oleg <olegm>
Sun 15 Jan 2006 07:13:16 PM UTC, comment #1: 

Please post output of diskinfo command

spiralvoice <spiralvoice>
Group administrator
Thu 20 Jul 2006 11:52:41 AM UTC, original submission:  

When mldonkey submits file with space at the end of filename, it logs following message:

2006/01/15 16:51:57 COPY ./temp/urn_ed2k_xxxxx TO ./incoming/xxxxx.avi
2006/01/15 16:51:57 [cInt] Exception in file_commit: Sys_error("./incoming/xxxxx.avi : No such file or directory")


The file appears in list of files to commit (although autocommit is set), but there seems to be no possibility to change file name.

Buildinfo:
MLNet Multi-Network p2p client version 2.7.2
Networks: Global Shares  Gnutella  G2  Fasttrack  FileTP  BitTorrent  Donkey
Ocaml version: 3.09.1
Build on: Linux i686 2.6.13-gentoo-r1 (little endian) with glibc 2.3.6
Configure arguments: --disable-gui
Features: threads zlib-1.2.3 bzip2-1.0.3 no-gd iconv no-check-bounds

Runinfo:
Enabled Networks:  Donkey BitTorrent FileTP
Server usage: enabled
System info: Linux olegm 2.6.13-gentoo-r1 #2 SMP Sat Sep 17 11:05:12 CEST 2005 i686
Uptime: 6h 4m 52s
Language: UK - locale: UTF-8 - UTC offset: +0100
 max_string_length: 16777211 - word_size: 32 - max_array_length: 4194303
 max file descriptors: 1024 - max useable file size: 2^63-1 bits (do the maths ;-p)

Oleg <olegm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10383:  filename_length.patch added by spiralvoice (13KiB - text/x-patch - updated version, thx to pango)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-07-20 spiralvoice CategoryNone Bug fixes
    StatusNone Done
    Open/ClosedOpen Closed
2006-07-20 spiralvoice SummaryReassigned item: mldonkey fails to submit file with space at the end of filename Removed spaces at end of filename when committing to FAT partition, shorten filename to max_name_len of filesystem
2006-07-20 spiralvoice Reassign itemFrom group mldonkey, a multi-networks file-sharing client, bugs tracker To group mldonkey, a multi-networks file-sharing client, patch tracker

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code