patchmldonkey, a multi-networks file-sharing client - Patches: patch #5277, MinGW: use new gettimeofday() from...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5277: MinGW: use new gettimeofday() from mingw-runtime-3.10

Submitter:  Schlumpf <schlumpf_>
Submitted:  Sun 06 Aug 2006 12:47:23 PM UTC
   
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Tue 15 Aug 2006 11:32:54 AM UTC, comment #5: 

Applied 2006/08/15

spiralvoice <spiralvoice>
Group administrator
Sun 06 Aug 2006 08:20:33 PM UTC, comment #4: 

-->>
The solution now in CVS leaves the possibility to compile
MLDonkey with older versions of MinGW.
<<--

if you think the way to go is to let mldonkey compileable from an older and buggy environment instead of fix this and make the proper changes (delete unnecassary code) to clean up the code from lengthy solutions is it ok for me.

by the way, after any time do you really think of it to make this changes sometime in future? ..... i think not


finally,
functions related to any os should be started with os_ not with ml_

the way to go for your solution is to call os_gettimeofday() in stubs_c.c without any '#if defined (_MINGW32_)' (for such things we have the os_stubs_c.c files)
and add os_gettimeofday() to config/unix/os_stubs_c.c wich called the real gettimeofday() function for unix.
Then change the ml_gettimeofday() in config/mingw/os_stubs_c.c to os_gettimeofday()
i think that would be the right (but nonetheless wrong) way

Schlumpf <schlumpf_>
Group Member
Sun 06 Aug 2006 06:36:57 PM UTC, comment #3: 
spiralvoice <spiralvoice>
Group administrator
Sun 06 Aug 2006 05:59:49 PM UTC, comment #2: 

this is not an duplicate of patch #5261, it fixes the useless solution of this patch.
We don't need to distinguish between mingw and Linux when calling gettimeofday() anymore because of the updated mingw-runtime where gettimeofday() is now available.

Schlumpf <schlumpf_>
Group Member
Sun 06 Aug 2006 02:03:08 PM UTC, comment #1: 

Duplicate of patch #5261 which is already in CVS.

spiralvoice <spiralvoice>
Group administrator
Sun 06 Aug 2006 12:47:23 PM UTC, original submission:  

since the mingw-runtime 3.10 gettimeofday() call is working, no need to write an extra function for this since then.

>>>> quote changes mingw-runtime-3.10 ->


2006-06-18 Danny Smith <dannysmith@users.sourceforge.net>
 

  • include/sys/time.h: Add header guard. Add extern "C" bracketing

for __cplusplus.
(gettimeofday): Add prototype.

  • mingwex/gettimeofday.c: New file.
  • mingwex/makefile.in: Add gettimeofday source and object.


<<<<

Schlumpf <schlumpf_>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10525:  mingw_gettimeofday_II.patch added by schlumpf_ (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 10 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-08-15 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
    Summarymingw: remove ml_gettimeofday() - mingw-runtime-3.10 is needet !! MinGW: use new gettimeofday() from mingw-runtime-3.10
2006-08-12 schlumpf_ Attached File- Added mingw_gettimeofday_II.patch, #10525
2006-08-12 spiralvoice Attached File#10472 Removed
2006-08-12 spiralvoice StatusDuplicate None
    Open/ClosedClosed Open
2006-08-06 spiralvoice StatusNone Duplicate
    Open/ClosedOpen Closed
2006-08-06 schlumpf_ Attached File- Added mingw_gettimeofday.patch, #10472

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code