mainSavannah Administration - Support: sr #110548, create an h-client git repository...

 
 

sr #110548: create an h-client git repository under the h-source project

Submitter:  Yuchen Pei <ycp>
Submitted:  Thu 14 Oct 2021 03:44:33 AM UTC
   
 
Category:  Additional Git repositories Priority:  5 - Normal
Severity:  3 - Normal Status:  Done
Privacy:  Public Assigned to:  ineiev
Operating System:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 14 Jun 2022 08:10:22 AM UTC, comment #17: 

Hmm, I accidentally posted a message in the wrong thread.  Please delete comment #16 if possible.

Yuchen Pei <ycp>
Tue 14 Jun 2022 08:06:03 AM UTC, comment #16: 


> Follow-up Comment #11, bug #60940 (project h-source):
>
> Hi Yuchen,
>
> comment #10:
>> I thought I could coordinate the work on h-client in this thread.  As it
> turned out I don't have time to review the code, nor the energy for drama.
>
> Thanks for the efforts, I think you are doing great!  There seems to be some
> point to clarify, if I may ask:
>
> Is there a consensus that the h-client source should be moved to the h-source
> project (under a separate code tree than h-source itself); it seems the
> request originated from you [0], and Bill had expressed their agreement with
> the idea in [1].
>
> [0]
> https://lists.nongnu.org/archive/html/h-source-users/2021-10/msg00015.html
> [1]
> https://lists.nongnu.org/archive/html/h-source-users/2021-10/msg00024.html
>
> It seems it never materialized; so perhaps the current two-projects structure
> was chosen (preserved) in the end?


These messages came from a savannah support ticket <https://savannah.nongnu.org/support/?110548> which was created by me, though [1] above did not appear in the ticket thread because the savannah ticket system is one way only (from web form to mailing list, not the other way around).

There was no consensus.  The Savannah admin wanted feedback from the h-client admins, but they didn't respond.  So the issue got stale and nothing was changed.

As I mentioned in the ticket, my goal was to separate out the h-client tree from the h-source tree.  Whether it was moved into a separate repo under the h-source project or into the h-client project was not important.  I chose the former because (IIRC) the h-client admins seemed unreachable, so if we were to leave the option of continuing working on the h-client code open, it would make more sense to do so under the h-source project, which I have been an admin.

Now the situation is different: I am an admin of h-client as well, so it makes more sense to choose the second option, i.e. hosting the h-client code under the h-client project, as 1) it requires no administrative overhead (requesting and waiting for the savannah admin to create a new project), 2) it is cleaner and less confusing ("empty" h-client project and an h-source project that hosts both h-source code and h-client code), and 3) these are two separate projects, with different purposes.  The h-client project does not require server administration / devops.  The h-node site does not require the h-client to run.  It is like having mastodon and mastodon clients like mastodon.el or toot in different repos.  Decoupling generally saves time and energy.

Regarding h-source, I also don't think it makes a lot of sense to bikeshed on which forge to use and where to write responses to bugs etc., as long as the current choice is not the bottleneck.  At this stage the bottleneck for the server development is the code quality / readability.  We need (more) tests for h-source, so that we can refactor the legacy code and make more interesting changes.  I am also not convinced the current number of active devs (basically 1) and time resources warrant long debates on that front.

I hope this answers your questions - let me know if you have more.

>
> Thanks,
>
> Maxim


Yuchen Pei <ycp>
Mon 01 Nov 2021 09:50:06 PM UTC, comment #15: 


comment #14:

> The message was delayed in the moderation queue,
> https://lists.nongnu.org/archive/html/h-source-users/2021-11/msg00005.html


You are right, thank you for fixing it!

Yuchen Pei <ycp>
Mon 01 Nov 2021 04:10:30 PM UTC, comment #14: 

The message was delayed in the moderation queue,
https://lists.nongnu.org/archive/html/h-source-users/2021-11/msg00005.html

Ineiev <ineiev>
Site Administrator
Mon 01 Nov 2021 10:21:42 AM UTC, comment #13: 
Yuchen Pei <ycp>
Fri 29 Oct 2021 07:36:18 AM UTC, comment #12: 

Please try again.

Ineiev <ineiev>
Site Administrator
Fri 29 Oct 2021 06:52:28 AM UTC, comment #11: 

Thank you, I'll work on it within a few days.

Ineiev <ineiev>
Site Administrator
Wed 27 Oct 2021 04:30:19 AM UTC, comment #10: 


comment #9:

> comment #7:
> > Would you entertain my other request about sending mails for commits in the predev branch?  That will save me the trouble of having to do something equivalent manually :)
>
> I've added the hook, but I'm not sure if it works; please check.


Thanks.  I made a test commit <https://git.savannah.nongnu.org/cgit/h-source.git/commit/?h=predev> but no email seems to have been sent https://lists.nongnu.org/archive/html/h-source-users/2021-10/threads.html

Yuchen Pei <ycp>
Fri 22 Oct 2021 07:10:27 AM UTC, comment #9: 

comment #8:

> Any updates on this?


I'd like to listen to what h-client admins say.

comment #7:

> Would you entertain my other request about sending mails for commits in the predev branch?  That will save me the trouble of having to do something equivalent manually :)


I've added the hook, but I'm not sure if it works; please check.

Ineiev <ineiev>
Site Administrator
Thu 21 Oct 2021 08:04:57 AM UTC, comment #8: 
Yuchen Pei <ycp>
Fri 15 Oct 2021 09:18:09 AM UTC, comment #7: 


comment #6:

> > I wouldn't close the h-client group or reassign the mailing list yet.
> >
> > My primary goal is to separate out the tree into its own repo, and I haven't worked on h-client, but will work on it in the future if I get time.
>
> It would be counterintuitive to look for h-client source in the h-source group.  That group already has a separate git repository, why don't you join h-client to work on it?


I can do that, though the h-client project seems to be inactive and the git repo there empty.  While I wait for their response, the h-client tree should be visible somewhere.  So if you don't want to create a h-client repo under h-source project, I'm gonna create a branch in the h-source repo named h-client for that purpose.

Would you entertain my other request about sending mails for commits in the predev branch?  That will save me the trouble of having to do something equivalent manually :)

Yuchen Pei <ycp>
Fri 15 Oct 2021 06:04:08 AM UTC, comment #6: 


> I wouldn't close the h-client group or reassign the mailing list yet.
>
> My primary goal is to separate out the tree into its own repo, and I haven't worked on h-client, but will work on it in the future if I get time.


It would be counterintuitive to look for h-client source in the h-source group.  That group already has a separate git repository, why don't you join h-client to work on it?

Ineiev <ineiev>
Site Administrator
Fri 15 Oct 2021 05:27:05 AM UTC, comment #5: 

Also the h-client project url is referenced in parabola[1] and guix[2] packages.  Removing it will cause a bit of extra work there.

[1] https://git.parabola.nu/abslibre.git/tree/pcr/h-client/PKGBUILD
[2] https://guix.gnu.org/en/packages/h-client-0.0a0-138/

Yuchen Pei <ycp>
Fri 15 Oct 2021 01:24:52 AM UTC, comment #4: 

comment #3:

> Should we close the h-client Savannah group and re-assign its mailing list to h-source? (I'd like to get a confirmation from an admin of h-client.)


I wouldn't close the h-client group or reassign the mailing list yet.

My primary goal is to separate out the tree into its own repo, and I haven't worked on h-client, but will work on it in the future if I get time.

Yuchen Pei <ycp>
Fri 15 Oct 2021 01:13:57 AM UTC, comment #3: 

Should we close the h-client Savannah group and re-assign its mailing list to h-source? (I'd like to get a confirmation from an admin of h-client.)

Ineiev <ineiev>
Site Administrator
Thu 14 Oct 2021 11:11:20 PM UTC, comment #2: 

Would it be possible to also arrange for commit diffs in the `predev` branch of the h-source repo to be sent to -email is unavailable- with [predev] prefix in the subject field?

Yuchen Pei <ycp>
Thu 14 Oct 2021 09:30:36 PM UTC, comment #1: 

I just committed a change so the h-client tree is removed, so link [3] in the original message should be replaced by

https://git.savannah.nongnu.org/cgit/h-source.git/tree/?h=development&id=9811e14665879801028e5ef088aa538cbb8b5f94

Yuchen Pei <ycp>
Thu 14 Oct 2021 03:44:33 AM UTC, original submission:  

h-source[1] is the web server software powering h-node.org.
h-client[2] is a client application interacting with h-node/h-source.

[1]: https://savannah.nongnu.org/projects/h-source/
[2]: https://savannah.nongnu.org/projects/h-client/

There is an h-client subdirectory in h-source git repo [3], which I would like to separate out. h-client has its own git repo[4] which appears to be empty.

[3]: https://git.savannah.nongnu.org/cgit/h-source.git/tree/h-client?h=development
[4]: https://git.savannah.nongnu.org/cgit/h-client.git

I have been mainly working on h-source, and based on what I have learned so far, I think it makes sense to separate out the h-client tree into a repo under h-source:

https://git.savannah.gnu.org/cgit/h-source/h-client.git/

as well as move the h-source repo one level deeper:

https://git.savannah.gnu.org/cgit/h-source/h-source.git/

and update the git repo links at h-client savannah page to link to the new repo.

Yuchen Pei <ycp>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ycp
  • -email is unavailable- added by ineiev (Posted a comment)
  • -email is unavailable- added by ycp (Submitted the item)
  • -email is unavailable- added by ycp
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-22 ineiev StatusNeed Info Done
        Open/ClosedOpen Closed
    2021-10-15 ycp Carbon-Copy- Added -email is unavailable-
    2021-10-15 ineiev StatusNone Need Info
        Assigned toNone ineiev
    2021-10-14 ycp Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code