taskmldonkey, a multi-networks file-sharing client - Tasks: task #4377, why not use relative refs in HTML...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #4377: why not use relative refs in HTML output?

Submitter:  Invalid User ID <#18297>
Submitted:  Fri 08 Jul 2005 09:33:44 AM UTC
   
 
Category:  HTTP interface Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed Should Start On:  Fri 08 Jul 2005 12:00:00 AM UTC
Should be Finished on:  Fri 08 Jul 2005 12:00:00 AM UTC

Jump to the original submission

Fri 06 Apr 2007 05:50:34 PM UTC, comment #10: 

This task should be fixed:

2006/11/05
5513: HTML: Let webinterface work in a HTML frame (ported from Knockers Mulus)
- third button row does not work yet, patches welcome

spiralvoice <spiralvoice>
Group administrator
Wed 17 May 2006 06:57:43 PM UTC, comment #9: 

Since its sometimes tedious to change absolute references to relative, how about adding an option to change the absolute root?

Joakim Verona <jave>
Group Member
Fri 08 Jul 2005 09:33:44 AM UTC, comment #8: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #3296

Following are the information included in the original report:

[field #0]                  Item ID: 3296
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #5]                 Category: HTTP interface
[field #6]             Submitted by: kisch
[field #7]              Assigned to: None
[field #8]             Submitted on: Mon 21.04.2003 um 20:28
[field #9]                  Summary: [enhancement] why not use relative refs in HTML output?
[field #10]      Original Submission: Hello, thanks for your great work!

Using relative refs in the generated HTML would enhance the possibilities to embed the mldonkey web interface into a larger apache setup.

If relative refs were used, a single apache ProxyPass directive would be sufficient to access the mldonkey web interface. As it is, the start frame contains requests to path-absolute URLs like e.g. /commands.html, so the following HTTP requests all need separate rewrite rules on their own.

And because the web browser assembles complete, absolute paths for the HTTP requests anyway from any relative path it sees in HTML, you wouldn t even have to change the HTTP request parsing code. Just drop the leading slashes from the output ;-)

[field #11]                Closed on: Don 19.05.2005 um 01:01
[field #12]               Item Group: Feature request
[field #13]                   Status: None
[field #14]        Component Version: None
[field #15]         Platform Version: Linux
[field #16]          Reproducibility: None
[field #17]               Size (loc): None
[field #18]            Fixed Release: None
[field #19]          Planned Release: None
[field #20]                   Effort: 0.00
[field #24]                 Priority: 5 - Normal
[field #27]         Percent Complete: 0%
[field #29]                  Release: None
[field #30]                  Release: 2.04rc1-0
[field #54]          Binaries Origin: Binary from Savannah
[field #55]                 CPU type: None
[field #56]                      CPU: None
[field #57]     Custom Select Box #4: None
[field #58]     Custom Select Box #5: None
[field #59]     Custom Select Box #6: None
[field #60]     Custom Select Box #7: None
[field #61]     Custom Select Box #8: None
[field #62]     Custom Select Box #9: None
[field #63]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Thu 26 May 2005 03:37:08 PM UTC, comment #7: 

That patch doesn't fix this.

Amorphous <amorphous>
Thu 19 May 2005 01:01:04 AM UTC, comment #6: 

Patch #4031 should solve this.

spiralvoice <spiralvoice>
Group administrator
Thu 19 May 2005 12:21:20 AM UTC, comment #5: 

fix fix fix ...

Anonymous
Thu 29 Apr 2004 04:29:16 PM UTC, comment #4: 

Reopened because fixing this would enable the html_mods interface to be used in a frame.

spiralvoice <spiralvoice>
Group administrator
Wed 25 Feb 2004 01:15:32 AM UTC, comment #3: 

Here is some more information about Apache redirection:
http://mldonkey.berlios.de/modules.php?name=Wiki&pagename=ApacheRedirection

spiralvoice <spiralvoice>
Group administrator
Fri 16 May 2003 06:06:48 PM UTC, comment #2: 

Thanks tharkun, for your very nice apache.conf hack!

for my apache I had to put "[P,L]" instead of "[P] [L]" at the end of the first RewriteRule.

Invalid User ID <#18297>
Tue 22 Apr 2003 07:42:29 AM UTC, comment #1: 

Im all for relative links but in the meantime, I use the following rewrite rules to not have to ProxyPass all URLs myself. This will make mldonkey available in /mldonkey on your apache.

RewriteCond      %{REQUEST_URI}           /mldonkey/.*
RewriteRule      .*/(.* ) http://www.my.dom:4080/$1 [P] [L]
# Rewrite the relative URI's mldonkey generates to use the /mldonkey/ prefix so the
# above rewrite rule can catch it.
RewriteCond      %{HTTP_REFERER}   .*apache.my.dom/mldonkey.*
RewriteRule      .*/(.*) http://apache.my.dom/mldonkey/$1 [R]

Invalid User ID <#18310>
Fri 08 Jul 2005 09:33:44 AM UTC, original submission:  

Hello, thanks for your great work!

Using relative refs in the generated HTML would enhance the possibilities to embed the mldonkey web interface into a larger apache setup.

If relative refs were used, a single apache ProxyPass directive would be sufficient to access the mldonkey web interface. As it is, the start frame contains requests to path-absolute URLs like e.g. /commands.html, so the following HTTP requests all need separate rewrite rules on their own.

And because the web browser assembles complete, absolute paths for the HTTP requests anyway from any relative path it sees in HTML, you wouldn't even have to change the HTTP request parsing code. Just drop the leading slashes from the output ;-)

Invalid User ID <#18297>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-04-06 spiralvoice StatusNone Done
        Open/ClosedOpen Closed
    2005-07-08 spiralvoice CategoryNone HTTP interface
    2005-07-08 spiralvoice SummaryReassigned item: [enhancement] why not use relative refs in HTML output? why not use relative refs in HTML output?
    2005-07-08 spiralvoice Reassign itemFrom group mldonkey, a multi-networks file-sharing client, bugs tracker To group mldonkey, a multi-networks file-sharing client, task tracker

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code