bugTransport Sample Protocol - Bugs: bug #20931, Use _WIN32 instead of WIN32

 
 

bug #20931: Use _WIN32 instead of WIN32

Submitted by:  Eric NOULARD <erk>
Submitted on:  Wed 29 Aug 2007 05:29:24 PM UTC  
 
Category:  Core Severity:  3 - Normal
Status:  Ready For Test Privacy:  Public
Assigned to:  Eric NOULARD <erk> Open/Closed:  Open
Release:  0.8.3 Fixed Release:  CVS

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 30 Nov 2007 03:44:29 PM UTC, comment #1: 

I've just committed the change.
Note that this was necessary because
WIN32 was defined by CMake and not by the Windows compiler
such that if you want to use TSP on Windows
you need to -DWIN32 if you were not using CMake.

Eric NOULARD <erk>
Project AdministratorIn charge of this item.
Wed 29 Aug 2007 05:29:24 PM UTC, original submission:  

We should use

_WIN32 macros instead of WIN32 which is not
a CPP macros but a MACRO defined by CMake.

see:
http://predef.sourceforge.net/preos.html#sec22

Eric NOULARD <erk>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by erk (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-11-30 erk CategoryNone => Core
        StatusNone => Ready For Test
        Assigned toNone => erk
        Fixed ReleaseUnknown => CVS

    Back to the top


    Powered by Savane 3.5