bugSamizdat - Bugs: bug #24091, dataset_cache_bug-0.1 [vs 080811...

 
 

bug #24091: dataset_cache_bug-0.1 [vs 080811 or 080703-2]: RdfDataSet fails to use optional parameter hash in cache key

Submitter:  Boud Roukema <boud>
Submitted:  Mon 18 Aug 2008 12:13:01 AM UTC
   
 
Category:  None Severity:  3 - Normal
Status:  Fixed Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 22 Oct 2008 04:52:32 PM UTC, comment #1: 

The fix committed to CVS, thanks!

Dmitry Borodaenko <angdraug>
Group administrator
Mon 18 Aug 2008 12:13:01 AM UTC, original submission:  

DESCRIPTION: RdfDataSet in engine/dataset.rb fails to use the optional parameter hash params for making the @cache_key sufficiently unique. This causes different dataset objects with the same query but different params to have identical values of @cache_key. The result is that the cache is not renewed even though it should be.

SEVERITY: This should not cause errors in presently existing snapshots or debian experimental versions of samizdat. However, for people using this functionality in writing patches or new features now or in the future, this is a bug waiting to cause failures to renew the cache in those patches/features. This is relevant for an upcoming updated monolanguage patch: https://savannah.nongnu.org/patch/?6167

SAMIZDAT VERSIONS: The bug is present in both 20080703-2 and 20080811-1.

FIX: One line fix attached as a patch file and also here on the nongnu.org page:


--- s080811/samizdat/lib/samizdat/engine/dataset.rb     2008-05-10 18:35:32.000000000 +0200
+++ /usr/lib/ruby/1.8/samizdat/engine/dataset.rb        2008-08-18 01:56:34.000000000 +0200
@@ -72,7 +72,7 @@
 class RdfDataSet < DataSet
   def initialize(query, limit = limit_page, params = {})
     super(query, limit)
-    @params = params
+    self.params = params
   end

   def params=(params)



Boud Roukema <boud>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -email is unavailable- added by angdraug (Posted a comment)
  • -email is unavailable- added by boud (Submitted the item)
  •  

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-10-22 angdraug StatusWorks For Me Fixed
        Open/ClosedOpen Closed
    2008-08-18 boud Dependencies- patch #6167 is dependent
    2008-08-18 boud Attached File- Added 080818_dataset_cache_bug.patch, #16306

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code