bugThe FreeType Project - Bugs: bug #27442, raster->buffer_size

 
 

bug #27442: raster->buffer_size

Submitted by:  None
Submitted on:  Mon 14 Sep 2009 07:20:39 AM UTC  
 
Severity: 3 - NormalItem Group: Incorrect behaviour
Status: FixedPrivacy: Public
Assigned to: Werner LEMBERG <wl>Open/Closed: Closed
Planned Release: 2.3.13

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 11 Mar 2010 05:28:04 PM UTC, comment #3:

Applied, thanks.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Thu 11 Mar 2010 05:08:31 PM UTC, comment #2:

Hi Werner,

We've stumbled on the same issue in our integration with Ghostscript, so......

Based on what's in the ant-aliasing code (ftgrays.c), I think that the buffer size stored in the Praster should be bytes (in ft_black_reset()), and it should be converted to Longs when setting up the Pworker structure (in ft_black_render()), so here's patch made on that assumption......

( attached ftraster.patch )

(file #19914)

Chris Liddell <chrisl>
Mon 21 Sep 2009 06:02:19 AM UTC, comment #1:

Thanks for your analysis. Can you provide a patch? Currently, I don't have time to work on this.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Mon 14 Sep 2009 07:20:39 AM UTC, original submission:

in raster\ftraster.c:
void ft_black_reset( )
{
//line 3322:
raster->buffer_size = ( ... ) / sizeof ( Long );
}
//so "buffer_size" means how many "long"s in buff.

static int ft_black_render( )
{
//line 3409:
worker->sizeBuff = worker->buff +
raster->buffer_size / sizeof ( Long );
}
//so "buffer_size" means how many "byte"s in buff

Yes, it just use a part of raster_pool, not crash the apply_program;
but it decrease the ras.maxBuff,
make Convert_Glyph( ) fail again and again,
waste lots of time in Render_Single_Pass( ).

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19914:  ftraster.patch added by chrisl (911B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by chrisl (Updated the item)
  • -unavailable- added by wl (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 11 Mar 2010 05:28:04 PM UTCwlStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
      Planned ReleaseNone=>2.3.13
    Thu 11 Mar 2010 05:08:31 PM UTCchrislAttached File-=>Added ftraster.patch, #19914
    Mon 21 Sep 2009 06:02:19 AM UTCwlStatusNone=>Confirmed
      Assigned toNone=>wl

    Back to the top


    Powered by Savane 3.1-cleanup1