bugDazuko - Bugs: bug #28045, dazukofs 3.1.1: Linux kernel crash...

 
 

bug #28045: dazukofs 3.1.1: Linux kernel crash in free_pid with ignore device

Submitter:  None
Submitted:  Wed 18 Nov 2009 12:50:31 PM UTC
   
 
Status:  Fixed Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 21 Nov 2009 07:19:15 PM UTC, comment #1: 

Thank you. You are absolutely correct. Version 3.1.2 has been released to address this issue.

John Ogness <ogman>
Group administrator
Wed 18 Nov 2009 12:50:31 PM UTC, original submission:  

Hi,

I get a more or less reproducible kernel crash on linux when using dazukofs with the program that opens the ignore device. The crash is not logged but I think I tracked it down and can provide a patch instead:

This is from ign_dev.c:

<pre>
int dazukofs_check_ignore_process(void)
{
        struct dazukofs_proc *proc;
        struct list_head *pos;
        int found = 0;
        struct pid *cur_proc_id = find_get_pid(task_pid_nr(current));

        mutex_lock(&ign_list_mutex);
        list_for_each(pos, &ign_list.list) {
                proc = list_entry(pos, struct dazukofs_proc, list);
                if (proc->proc_id == cur_proc_id) {
                        found = 1;
                        put_pid(proc->proc_id); <=== XXXX
                        break;
                }
        }
        mutex_unlock(&ign_list_mutex);

        put_pid(cur_proc_id);

        return !found;
}
</pre>

The line marked XXX (put_pid(proc->proc_id);) must be removed:
The reference to the pid that is acquired by find_get_pid is dropped after the list_for_eatch loop and the reference held by the list itself must not be dropped because the entry is not removed from the list.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ogman (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-11-21 ogman StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code