bugWeeChat - Bugs: bug #29879, Auto-split is limited and doesn't...

 
 

bug #29879: Auto-split is limited and doesn't work for /me or dcc chat sessions

Submitted by:  Michael J Evans <mjevans>
Submitted on:  Fri 14 May 2010 07:54:54 AM UTC  
 
Category:  irc plugin Severity:  3 - Normal
Item Group:  irc protocol Status:  Fixed
Privacy:  Public Assigned to:  Sebastien Helleu <flashcode>
Originator Name:  Open/Closed:  Closed
Release:  0.3.2 IRC nick:  MJEvans

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 26 Aug 2011 08:44:15 AM UTC, comment #1:

Done. But colors are not preserved in cut of messages (IMHO, it would make more complex code, for something not really useful).

So with fix:
- privmsg is split correctly (CTCP is preserved)
- /me is split
- other messages are split: ison, join, notice, wallops, 005, 353
- messages sent by relay plugin to clients of irc proxy are split.

For dcc chat (xfer), I think it's not needed to split messages since there is no IRC server between partners (tell me if I'm wrong). Moreover, it's not an IRC message (with PRIVMSG), but only a string with a final new line char. I made some tests with some other IRC clients, no problem with large messages.

And this split is accessible to other plugins/scripts with new info_hashtable called "irc_message_split".

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Fri 14 May 2010 07:54:54 AM UTC, original submission:

Currently weechat has auto-splitting for normal text only; with the following detractions.

  • Doesn't work for /me (actions)
  • Doesn't work for dcc chat (xfer plugin)
  • Doesn't preserve current color/other state

I have a patch set which fixes all of the above issues, and 20100514-07:51:22 Veinor!~Veinor@XVM-ONE-160.MIT.EDU): Patrick has asked the following in #weechat (in a quite timely manor)

20100514-07:38:25 Veinor | Does weechat have any support for auto-wrapping long lines?
20100514-07:42:00 MJEvans | Veinor: rephrase, do not use wrapping
20100514-07:42:25 Veinor | I mean... if I enter a really, really long line into the input area
20100514-07:42:31 Veinor | is there any support for automatically breaking it up?
20100514-07:42:50 MJEvans | it will auto-split normal text on non DCC chat buffers.
20100514-07:43:17 MJEvans | It /currently/ will not auto split DCC buffers to work with broken clients, nor will it auto-split 'actions' (/me does something long)
20100514-07:43:42 Veinor | yeah, the actions are what I need split. :P

Michael J Evans <mjevans>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #20533:  improved-split.patch added by mjevans (28KiB - text/x-diff - Current whole-patch.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by flashcode (Updated the item)
  • -email is unavailable- added by mjevans (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-10-22 flashcode Open/ClosedOpen => Closed
    2011-08-26 flashcode StatusConfirmed => Fixed
    2010-06-18 flashcode Item Groupother => irc protocol
        StatusNone => Confirmed
        Assigned toNone => flashcode
        Release2.4-dev => 0.3.2
    2010-05-14 mjevans Attached File- => Added improved-split.patch, #20533

    Back to the top


    Powered by Savane 3.4