bugGPSD - Bugs: bug #36914, valgrind-audit: missing dependency...

 
 

bug #36914: valgrind-audit: missing dependency and local path

Submitter:  Olivier Cornu <ocornu>
Submitted:  Sat 21 Jul 2012 04:10:32 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  esr
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 22 Jul 2012 05:36:56 PM UTC, comment #3: 

Actually, valgrind-audit also depends on gpsd (it uses fake.py to spawn a test gpsd daemon).
I first missed it because fake.py default behavior is to use the installed gpsd binary, not the local one you've just built (#36919). Thus, valgrind-audit worked fine even when gpsd had not been built.

Olivier Cornu <ocornu>
Sat 21 Jul 2012 04:20:25 PM UTC, comment #2: 

flocktest suffers from the same missing local path issue.
Trivial patch attached.


(file #26238)

Olivier Cornu <ocornu>
Sat 21 Jul 2012 04:14:14 PM UTC, comment #1: 

Trivial patch.

(file #26237)

Olivier Cornu <ocornu>
Sat 21 Jul 2012 04:10:32 PM UTC, original submission:  

SConstruct does not honor valgrind-audit dependency on python_built_extensions.
Thus, a "scons valgrind-audit" command (in a clean project) fails with:

valgrind-audit.py
Traceback (most recent call last):
  File "./valgrind-audit.py", line 10, in <module>
    import sys, gps.fake
  File "/home/olivier/dev/gpsd/gps/fake.py", line 70, in <module>
    import packet as sniffer
ImportError: No module named packet
scons: *** [valgrind-audit] Error 1
scons: building terminated because of errors.


How to reproduce:

$ scons -c; scons valgrind-audit



A second issue is a missing (implied) local path when the call to valgrind-audit.py is made.
Thus, if $PATH does not contain '.', "scons valgrind-audit" fails with:

valgrind-audit.py
sh: 1: valgrind-audit.py: not found
scons: *** [valgrind-audit] Error 127
scons: building terminated because of errors.


Olivier Cornu <ocornu>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #26238:  commit-2270d09 added by ocornu (735B - application/octet-stream - flocktest patch)
file #26237:  commit-bb2b4a9 added by ocornu (931B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by esr (Updated the item)
  • -email is unavailable- added by ocornu (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-09-09 esr Open/ClosedOpen Closed
    2012-07-31 esr StatusNone Fixed
        Assigned toNone esr
    2012-07-21 ocornu Attached File- Added commit-2270d09, #26238
    2012-07-21 ocornu Attached File- Added commit-bb2b4a9, #26237

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code