bugGPSD - Bugs: bug #36914, valgrind-audit: missing dependency...

 
 

bug #36914: valgrind-audit: missing dependency and local path

Submitted by:  Olivier Cornu <ocornu>
Submitted on:  Sat 21 Jul 2012 04:10:32 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Eric S. Raymond <esr>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 22 Jul 2012 05:36:56 PM UTC, comment #3:

Actually, valgrind-audit also depends on gpsd (it uses fake.py to spawn a test gpsd daemon).
I first missed it because fake.py default behavior is to use the installed gpsd binary, not the local one you've just built (#36919). Thus, valgrind-audit worked fine even when gpsd had not been built.

Olivier Cornu <ocornu>
Sat 21 Jul 2012 04:20:25 PM UTC, comment #2:

flocktest suffers from the same missing local path issue.
Trivial patch attached.

(file #26238)

Olivier Cornu <ocornu>
Sat 21 Jul 2012 04:14:14 PM UTC, comment #1:

Trivial patch.

(file #26237)

Olivier Cornu <ocornu>
Sat 21 Jul 2012 04:10:32 PM UTC, original submission:

SConstruct does not honor valgrind-audit dependency on python_built_extensions.
Thus, a "scons valgrind-audit" command (in a clean project) fails with:

How to reproduce:

A second issue is a missing (implied) local path when the call to valgrind-audit.py is made.
Thus, if $PATH does not contain '.', "scons valgrind-audit" fails with:

Olivier Cornu <ocornu>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #26238:  commit-2270d09 added by ocornu (735B - application/octet-stream - flocktest patch)
file #26237:  commit-bb2b4a9 added by ocornu (931B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by esr (Updated the item)
  • -unavailable- added by ocornu (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 09 Sep 2012 06:55:39 PM UTCesrOpen/ClosedOpen=>Closed
    Tue 31 Jul 2012 05:12:14 AM UTCesrStatusNone=>Fixed
      Assigned toNone=>esr
    Sat 21 Jul 2012 04:20:25 PM UTCocornuAttached File-=>Added commit-2270d09, #26238
    Sat 21 Jul 2012 04:14:14 PM UTCocornuAttached File-=>Added commit-bb2b4a9, #26237

    Back to the top


    Powered by Savane 3.1-cleanup1