bugWeeChat - Bugs: bug #37671, Presence of libgcrypt is not...

 
 

bug #37671: Presence of libgcrypt is not checked during configure

Submitted by:  Nemunaire <nemunaire>
Submitted on:  Mon 05 Nov 2012 10:30:20 PM UTC  
 
Category:  compilation Severity:  3 - Normal
Item Group:  compile/install Status:  Fixed
Privacy:  Public Assigned to:  Sebastien Helleu <flashcode>
Originator Name:  Open/Closed:  Closed
Release:  0.3.9 IRC nick:  nemunaire

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 06 Nov 2012 11:15:54 AM UTC, comment #3:

The check for gcrypt lib is made in src/CMakeLists.txt:

# Check for libgcrypt
FIND_PACKAGE(Gcrypt REQUIRED)
ADD_DEFINITIONS(-DHAVE_GCRYPT)
LIST(APPEND EXTRA_LIBS ${GCRYPT_LDFLAGS})

As you can see, it is supposed to be "REQUIRED", so cmake should stop immediately if gcrypt is not found.
But when I tried, cmake did not display any error, and you can compile sources (with the errors you have).
I'll look at this problem.

By the way, you can remove the cmake flag "-DENABLE_GCRYPT=ON", it's now obsolete because gcrypt is required (this option has been removed from main CMakeLists.txt in version 0.3.9).

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Tue 06 Nov 2012 10:41:11 AM UTC, comment #2:

I actually used cmake for the compilation, with those options:
-DENABLE_NCURSES=ON -DENABLE_LARGEFILE=ON -DENABLE_DEMO=OFF -DENABLE_GTK=OFF -DENABLE_NLS=ON -DENABLE_GCRYPT=ON -DENABLE_ASPELL=ON -DENABLE_CHARSET=ON -DENABLE_FIFO=OFF -DENABLE_IRC=ON -DENABLE_LOGGER=OFF -DENABLE_RELAY=ON -DENABLE_SCRIPTS=ON -DENABLE_PERL=OFF -DENABLE_PYTHON=ON -DENABLE_RUBY=OFF -DENABLE_LUA=OFF -DENABLE_TCL=OFF-DENABLE_GUILE=OFF -DENABLE_DOC=OFF

I attach the file build.log which is a full log of the automatic compilation procedure on my distribution; this time in english and without distcc.

Furthermore, I try to execute the configure script and it effectively fails on libgcrypt (I attach the configure log in configure.log).

I'm not used to cmake, but contrary to configure.in that have a gcrypt part, I didn't find the same part in the CMakeLists.txt

(file #26881, file #26882)

Nemunaire <nemunaire>
Tue 06 Nov 2012 07:04:17 AM UTC, comment #1:

The gcrypt lib is supposed to be detected by both cmake and configure, and gcrypt is mandatory since v0.3.9.

By the way, cmake is the only recommended way to compile WeeChat, the configure script may be removed in future).

So please paste full log using cmake (or configure if you can really not use cmake).
Please run the script with english locale (I'm french, but other people will not be able to understand).

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Mon 05 Nov 2012 10:30:20 PM UTC, original submission:

The compilation failed if libgcrypt is not installed, in both stable (from 0.3.9) and in dev release :

weechat-0.3.9/src/plugins/irc/irc-sasl.c:29:20: erreur fatale: gcrypt.h : Aucun fichier ou dossier de ce type

Nemunaire <nemunaire>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #26881:  build.log added by nemunaire (148KiB - text/x-log)
file #26882:  configure.log added by nemunaire (12KiB - text/x-log)
file #26879:  build.log added by nemunaire (211KiB - text/x-log)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by flashcode (Posted a comment)
  • -email is unavailable- added by nemunaire (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-01-20 flashcode Open/ClosedOpen => Closed
    2012-11-06 flashcode StatusConfirmed => Fixed
    2012-11-06 flashcode StatusNeed Info => Confirmed
    2012-11-06 nemunaire Attached File- => Added build.log, #26881
        Attached File- => Added configure.log, #26882
    2012-11-06 flashcode StatusNone => Need Info
        Assigned toNone => flashcode
    2012-11-05 nemunaire Attached File- => Added build.log, #26879

    Back to the top


    Powered by Savane 3.4