bugGPSD - Bugs: bug #46941, gpsd build fails on OSX <10.6

 
 

bug #46941: gpsd build fails on OSX <10.6

Submitted by:  Fred Wright <fhgwright>
Submitted on:  Thu 21 Jan 2016 12:21:38 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Eric S. Raymond <esr>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 21 Jan 2016 12:31:46 AM UTC, comment #1:

OSX versions earlier than 10.6 fail to define IPV6_TCLASS, causing the compile of gpsd.c to fail. There is already a fallback definition for Gnu/Hurd. The attached patch:

1) Extends the existing Gnu/Hurd fallback definition to include a case for OSX. This is currently based on _APPLE_. Basing it on Darwin might be more appropriate, but that would need to be tested.

2) Duplicates this fallback setup in netlib.c, where it was missing.

3) Adds an ifdef to gpsd.c so that other cases that fail to define IPV6_TCLASS will simply omit the IPTOS_LOWDELAY setup, rather than failing to build. It's not entirely clear that sweeping the problem under the rug is preferable to getting an error and having the builder figure out what to do, but it is consistent with netlib.c, which includes a similar ifdef.

The patch is originally from jeremyhu@macports.org, updated for 3.14 by ryandesign@macports.org, and then updated by me for 3.16.

(file #36105)

Fred Wright <fhgwright>
Project Member
Thu 21 Jan 2016 12:21:38 AM UTC, original submission:
Fred Wright <fhgwright>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #36105:  leopard-IPV6_TCLASS.patch added by fhgwright (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by esr (Updated the item)
  • -unavailable- added by fhgwright (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 07 Sep 2017 04:33:24 AM UTCesrOpen/ClosedOpen=>Closed
    Thu 21 Jan 2016 06:38:00 PM UTCesrStatusNone=>Fixed
      Assigned toNone=>esr
    Thu 21 Jan 2016 12:31:46 AM UTCfhgwrightAttached File-=>Added leopard-IPV6_TCLASS.patch, #36105

    Back to the top


    Powered by Savane 3.1-cleanup1