bugGPSD - Bugs: bug #46941, gpsd build fails on OSX <10.6

 
 

bug #46941: gpsd build fails on OSX <10.6

Submitter:  Fred Wright <fhgwright>
Submitted:  Thu 21 Jan 2016 12:21:38 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  esr
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 21 Jan 2016 12:31:46 AM UTC, comment #1: 

OSX versions earlier than 10.6 fail to define IPV6_TCLASS, causing the compile of gpsd.c to fail.  There is already a fallback definition for Gnu/Hurd.  The attached patch:

1) Extends the existing Gnu/Hurd fallback definition to include a case for OSX.  This is currently based on _APPLE_.  Basing it on Darwin might be more appropriate, but that would need to be tested.

2) Duplicates this fallback setup in netlib.c, where it was missing.

3) Adds an ifdef to gpsd.c so that other cases that fail to define IPV6_TCLASS will simply omit the IPTOS_LOWDELAY setup, rather than failing to build.  It's not entirely clear that sweeping the problem under the rug is preferable to getting an error and having the builder figure out what to do, but it is consistent with netlib.c, which includes a similar ifdef.

The patch is originally from jeremyhu@macports.org, updated for 3.14 by ryandesign@macports.org, and then updated by me for 3.16.


(file #36105)

Fred Wright <fhgwright>
Group Member
Thu 21 Jan 2016 12:21:38 AM UTC, original submission:  


Fred Wright <fhgwright>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #36105:  leopard-IPV6_TCLASS.patch added by fhgwright (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by esr (Updated the item)
  • -email is unavailable- added by fhgwright (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-09-07 esr Open/ClosedOpen Closed
    2016-01-21 esr StatusNone Fixed
        Assigned toNone esr
    2016-01-21 fhgwright Attached File- Added leopard-IPV6_TCLASS.patch, #36105

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code