bugGPSD - Bugs: bug #52347, No define for current proto_major

 
 

bug #52347: No define for current proto_major

Submitted by:  Gary E. Miller <garyemiller>
Submitted on:  Mon 06 Nov 2017 12:13:38 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 06 Nov 2017 08:27:07 PM UTC, comment #1:

From: "Michael J. Tubby B.Sc. MIET" <mike.tubby@thorcom.co.uk>

I think the issue is that we're trying to version control several things:

1. GPSD itself, e.g. 'release' 3.17 which has a major of '3' and a minor of '17'

2. GPSD's most recent version, e.g. major '3' and minor '12' since nothing external has changed between 3.12 and 3.17

3. The JSON protcol interface level - which may also be 3.12 (or
something different)

4. the libgps API version, which appears to be 6.1

Perhaps version_t needs to be bumped from:

struct version_t {
    char release[64];                   /* external version */
    char rev[64];                       /* internal revision ID */
    int proto_major, proto_minor;       /* API major and minor versions */
    char remote[GPS_PATH_MAX];          /* could be from a remote device */
};

to:

struct version_t {
    char release[64];                   /* external version */
    char rev[64];                       /* internal revision ID */
    int release_major, release_minor,   /* release as two part integers */
    int proto_major, proto_minor;       /* JSON protocol major and
minor versions */
    int api_major, api_minor;           /* API (libgps) major and minor
versions */
    char remote[GPS_PATH_MAX];          /* could be from a remote device */
};

then we'd have everything and it could be testable programmatically.

Gary E. Miller <garyemiller>
Project Administrator
Mon 06 Nov 2017 12:13:38 AM UTC, original submission:

A client should check that proto_major matches the expected API version, but there is not define for is. The current API version is 3.1, but GPSD_API_MAJOR_VERSION is currently 6.

Did the API version and daemon version get switched?

Gary E. Miller <garyemiller>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by garyemiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item

    Back to the top


    Powered by Savane 3.1-cleanup1