bugpktools - Bugs: bug #53082, Path to set library install path

 
 

bug #53082: Path to set library install path

Submitted by:  Bas Couwenberg <sebastic>
Submitted on:  Wed 07 Feb 2018 08:35:21 AM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Ready For Test
Privacy:  Public Assigned to:  Pieter kempeneers <kempenep>
Open/Closed:  Open Operating System:  GNU/Linux

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sun 25 Nov 2018 01:05:58 PM UTC, comment #6: 

should now be fixed 2.6.7.6

Pieter kempeneers <kempenep>
Project AdministratorIn charge of this item.
Sat 24 Nov 2018 10:21:22 PM UTC, comment #5: 

Note that the build fails when using set() instead of option() as in multiarch.patch.

Bas Couwenberg <sebastic>
Mon 23 Apr 2018 05:21:45 PM UTC, comment #4: 

Do you want an updated patch that uses set() instead of option(), or can you apply the patch as-is and change that line yourself?

Bas Couwenberg <sebastic>
Wed 07 Feb 2018 02:35:07 PM UTC, comment #3: 

set() should work too and may be more appropriate as option() is mostly for ON/OFF values.

Bas Couwenberg <sebastic>
Wed 07 Feb 2018 02:21:11 PM UTC, comment #2: 

Could it be that in the patch the "option" should actually be a "set"?

That is, replace:
+option (INSTALL_LIBRARY_DIR "Install path for libraries" ${PROJECT_LIBRARY_DIR})

with:
set(INSTALL_LIBRARY_DIR ${PROJECT_LIBRARY_DIR} CACHE PATH "Install path for libraries")

Pieter kempeneers <kempenep>
Project AdministratorIn charge of this item.
Wed 07 Feb 2018 10:12:41 AM UTC, comment #1: 

Patch accepted. Thanks, I will integrate the patch in the next release.

Pieter kempeneers <kempenep>
Project AdministratorIn charge of this item.
Wed 07 Feb 2018 08:35:21 AM UTC, original submission:  

On Debian/Ubuntu systems the shared libraries and pkg-config files should be installed in the Multi-Arch path [0].

Currently the library install path is hardcoded, the attached patch makes it configurable with an option keeping the default as it was before.

[0] https://wiki.debian.org/Multiarch

Bas Couwenberg <sebastic>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #45519:  multiarch.patch added by sebastic (3KiB - text/x-patch - Update patch with set() instead of option())
file #43198:  library-path.patch added by sebastic (3KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by kempenep (Posted a comment)
  • -email is unavailable- added by sebastic (Submitted the item)
  • -email is unavailable- added by sebastic
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-11-25 kempenep StatusNeed Info => Ready For Test
    2018-11-24 sebastic Attached File- => Added multiarch.patch, #45519
    2018-02-07 kempenep StatusConfirmed => Need Info
    2018-02-07 kempenep StatusNone => Confirmed
        Assigned toNone => kempenep
    2018-02-07 sebastic Attached File- => Added library-path.patch, #43198
        Carbon-Copy- => Added sebastic@xs4all.nl

    Back to the top


    Powered by Savane 3.5