Add a New Comment (Rich Markup)
I am unsure either. IIRC the fix was in ADVCFConverter.m (checking _idx which was causing the exception). I don't remember exactly, but I believe I thought giving preference to UTF-8 is necessary for efficiency (nowadays it's more likely a .vcf file to be UTF-8). Checking the code now, it seems it was really necessary because -initWithData:encoding: with NSUnicodeStringEncoding used for UTF-8 or ISO-8859 string will not return nil but garbage. The attached little program demonstrates this. So the "if (string)" check is insufficient. (file #52598, file #52599, file #52600)
I am unsure this fix is generally correct - sure it gives precedence to UTF8, so it probably fixes your case which has an UTF8 file. But all encodings type are tested - it seems to me then that something valid is initialized even if the encoding is not correct? What encoding is your file?
The attached patch fixes it for me. (file #43473)
AddressManager (and adtool) cannot import .vcf files from Evolution or KAdrressBook, in fact it can't import even its own exported files. 2018-03-05 19:46:14.189 adtool[16790:16790] File in NSUnicodeStringEncoding 2018-03-05 19:46:14.191 adtool[16790:16790] Syntax error in line 0!
(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)
Attach Files: Comment:
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Only logged-in users can vote.
Please enter the title of George Orwell's famous dystopian book (it's a date):
Follow 4 latest changes.
Copyright © 2023 Free Software Foundation, Inc. Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved. The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team. Source Code
Powered by Savane 3.11