The FreeType Project - Bugs: bug #56067, PCF defaultChar changes in 2.10...
You are not allowed to post comments on this tracker with your current authentication level.
bug #56067: PCF defaultChar changes in 2.10 causes FontConfig to mis-detect(?) charsets
Submitter: | None | ||
Submitted: | Wed 03 Apr 2019 07:17:50 PM UTC | ||
Severity: | 3 - Normal | Item Group: | Incorrect behaviour |
Status: | Fixed | Privacy: | Public |
Assigned to: | wl | Open/Closed: | Closed |
Planned Release: | 2.10.1 |
Jump to the original submission
Mon 22 Apr 2019 06:34:55 PM UTC, comment #16: |
Alexei Podtelezhnikov <podtelez> |
Mon 22 Apr 2019 05:26:37 PM UTC, comment #15: This doesn't work. Glyph index 0 must be used only for the missing glyph, because `FT_Get_Next_Char' stops as soon as it encounters glyph index 0. However, the PCF `defaultChar' is used as a real character also. It thus must be duplicated.
|
Werner LEMBERG <wl> |
Mon 22 Apr 2019 01:45:12 PM UTC, comment #14: Purely cosmetically, would it make sense to check if .notdef is already at offset = 0? This way it would not be duplicated.
|
Alexei Podtelezhnikov <podtelez> |
Fri 19 Apr 2019 08:53:32 AM UTC, comment #13: Looks good as far as I can tell. I tested with Dina, TerminusV and a couple of artwiz fonts and I didn't notice any issues.
|
Daniel Eklöf <dnkl> |
Fri 19 Apr 2019 05:05:35 AM UTC, comment #12: It should be fixed now in git, please test. |
Werner LEMBERG <wl> |
Mon 15 Apr 2019 06:14:50 PM UTC, comment #11: I'm working on a fix. |
Werner LEMBERG <wl> |
Mon 15 Apr 2019 03:53:43 PM UTC, comment #10: Werner,
|
Alexei Podtelezhnikov <podtelez> |
Sat 06 Apr 2019 09:35:06 AM UTC, comment #9: Sorry if my last couple of posts have been confusing; I've been
|
Daniel Eklöf <dnkl> |
Fri 05 Apr 2019 08:57:59 PM UTC, comment #8: The gohu font is invalid; its default character has index 0, however, this glyph doesn't exist in the font (i.e., the font's encoding slot at position 0 is marked as 0xFFFF).
|
Werner LEMBERG <wl> |
Thu 04 Apr 2019 12:00:39 PM UTC, comment #7: Or are the fonts broken; should they be using a different default glyph?
|
Daniel Eklöf <dnkl> |
Thu 04 Apr 2019 10:50:06 AM UTC, comment #6: I did a quick hack where I modified pcf_cmap_char_next to return the original default character encoding offset when we encounter the default character.
|
Daniel Eklöf <dnkl> |
Thu 04 Apr 2019 08:52:33 AM UTC, comment #5: Hmm, the initial problem, solved by the patch, is that FT_Get_Next_Char returned *agindex == 0 for the character before the default character.
|
Daniel Eklöf <dnkl> |
Thu 04 Apr 2019 08:21:34 AM UTC, comment #4: Thanks for the pointer. That patch does seem to fix most of the issues I've seen.
|
Daniel Eklöf <dnkl> |
Thu 04 Apr 2019 07:33:27 AM UTC, comment #3: A patch was posted on the freetype-devel list:
|
Werner LEMBERG <wl> |
Thu 04 Apr 2019 06:37:35 AM UTC, comment #2: Yes, those are the original fonts. (I'm the reporter btw)
|
Daniel Eklöf <dnkl> |
Wed 03 Apr 2019 08:09:49 PM UTC, comment #1: Are these the original fonts in question?
|
Alexei Podtelezhnikov <podtelez> |
Wed 03 Apr 2019 07:17:50 PM UTC, original submission:
There's a long thread over at the arch forums,
|
Anonymous |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 9 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2019-04-19 | wl | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
Planned Release | None | 2.10.1 | |||
2019-04-15 | wl | Status | Need Info | In Progress | |
2019-04-08 | crem | Carbon-Copy | - | Added crem | |
2019-04-04 | wl | Status | None | Need Info | |
Assigned to | None | wl | |||
2019-04-04 | dnkl | Attached File | - | Added DinaMedium10.pcf.gz, #46719 | |
2019-04-03 | dnkl | Carbon-Copy | - | Added dnkl |
Powered by Savane 3.13-d3ae.
Corresponding source code
I see. Those are actually .notdef and .null rather than duplicates in the UCS misc-fixed fonts.
FreeType does not read PCF_GLYPH_NAMES table. Therefore it was not obvious.