bugdavfs2 - Bugs: bug #58100, Portability fixes for musl libc

 
 

bug #58100: Portability fixes for musl libc

Submitted by:  None
Submitted on:  Thu 02 Apr 2020 11:27:21 AM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  In Progress
Privacy:  Public Assigned to:  Werner Baumann <wbaumann>
Open/Closed:  Open

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 04 Apr 2020 08:26:53 AM UTC, comment #1: 

Thanks for the patch. I will include some of them. But there are some others that need clarification and improvement:

  • Replacement for rpmatch: rpmatch is localized and the message from davfs2 is localized too. So the replacement code must accept answers in the same language as the message. I think that could be done using gettext. Any proposal?
  • conanonicalize_file_name: As far as I know realpath(char *path, NULL) behaves exactly like canonicalize_file_name. This is standardized in POSIX.1-2008 (allocating the buffer as needed). Does musl libc support it? I intended to change to realpath anyway.
  • error_at line: I prefer to use error instead and add filename and line number in the message string of error. This will  avoid the need for that compat file. I will do this.
  • error.h: Moving the include <error.h> into another header would break the coding style. Instead I will make the include conditional in every source file where it is needed.
  • Neon error messages: printing the neon error messages into the logfile proved to be very useful and disabling it would be a big disadvantage. Havn't you any better idea how to replace that missing function? Disabling this feature would be the last resort.

Werner

Werner Baumann <wbaumann>
Project AdministratorIn charge of this item.
Thu 02 Apr 2020 11:27:21 AM UTC, original submission:  

Hi,

I'd like to get our (voidlinux) patches merged upstream that allow us to build davfs2-1.5.6 in both glibc and musl.

We were using these patches a while ago and nobody has reported any issue so I assume these are ok.

Patches attached.

Thanks.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #48735:  010-main_code_fix.patch added by None (534B - application/octet-stream)
file #48736:  100-musl-compat.patch added by None (5KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by wbaumann (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-04-04 wbaumann StatusNone => In Progress
        Assigned toNone => wbaumann
    2020-04-02 None Attached File- => Added 010-main_code_fix.patch, #48735
        Attached File- => Added 100-musl-compat.patch, #48736

    Back to the top


    Powered by Savane 3.7