bugManeage - Bugs: bug #58260, Fix pkg-config bug in basic.mk

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #58260: Fix pkg-config bug in basic.mk

Submitter:  Boud Roukema <boud>
Submitted:  Mon 27 Apr 2020 03:21:35 PM UTC
   
 
Category:  Software Severity:  5 - Blocker
Item Group:  Crash Status:  Works For Me
Privacy:  Public Assigned to:  makhlaghi
Open/Closed:  Closed

Mon 27 Apr 2020 11:57:42 PM UTC, comment #3: 

OK, good point - if I propose fixes that are closely related
I'll put them on a single branch. I haven't done commit squishing
for some time, but I like the idea.

Boud Roukema <boud>
Group Member
Mon 27 Apr 2020 11:52:57 PM UTC, comment #2: 

Thanks Boud, they are both now merged into Maneage (commits e43e3291 and 2fb0b2a92).

I am closing this bug.

After your reporting of this problematic case, I went through the list of software (in `reproduce/software/config/versions.conf') again and found two others and corrected them with the second commit.

Unfortunately I rushed a little in pushing, so we have two very similar commits in Maneage. It would have been better (for the users following the changes who want to update their projects) if the two related commits were "squashed" into one commit.

In future such cases (when the fixes are related and you have already pushed one fix to a remote branch), it will help me if you continue pushing to the same branch. This is your repository, so I can't delete any branches and there is no chance of loosing your work ;-). But if they were both in one branch, I would be more clearly reminded to rebase them as one commit ;-).

Mohammad Akhlaghi <makhlaghi>
Group administrator
Mon 27 Apr 2020 09:56:54 PM UTC, comment #1: 
Boud Roukema <boud>
Group Member
Mon 27 Apr 2020 03:21:35 PM UTC, original submission:  

Until commit 3409a54 from yesterday, pkg-config was found
correctly in `reproduce/software/make/basic.mk` by searching for
`pkg`. However, commit a21ea20 made an improvement in the regular
expression for relating package names and download filenames, and
the string `pkg-config` with the new regex no longer simplifies
to `pkg`. The result of this was that the basic.mk could not find
`pkg-config` in the list of packages, since it was still listed as
`pkg`. This blocked downloading for a system without pkg-config
preloaded.

With this commit of just a few bytes, the bug appears to be
fixed: https://codeberg.org/boud/maneage_dev/commit/5231441ec26763f6c8631d172a81db1f95853c94

The fix is in the branch fix_pkgconfig_bug at codeberg:
https://codeberg.org/boud/maneage_dev/branches/

It should be possible to reproduce the bug by removing all
signs of pkg-config/pkgconfig being installed in the system,
including its tarball, and trying `./project configure --existing-conf`.

Boud Roukema <boud>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Posted a comment)
  • -email is unavailable- added by boud (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-04-27 makhlaghi Item GroupNone Crash
        Assigned toNone makhlaghi
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code