bugattr - Bugs: bug #63670, [PATCH] Add Cygwin support

 
 

bug #63670: [PATCH] Add Cygwin support

Submitter:  None
Submitted:  Sun 15 Jan 2023 01:34:50 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 15 Jan 2023 02:22:47 PM UTC, comment #1: 

After creating this patch, I scanned the mailing list archive
and to my surprise I found
https://lists.nongnu.org/archive/html/acl-devel/2022-12/msg00020.html

With this patch on top of attr's master branch, there's no
reason anymore to apply my Cygwin-specific patch from this
bug report.  The missing "-no-undefined" in libattr_la_LDFLAGS
to build a libattr DLL on Cygwin can easily be added via the
attr spec file creating the Cygwin distro package.

So, question is, is https://lists.nongnu.org/archive/html/acl-devel/2022-12/msg00020.html
about to be merged into attr master?

Thanks,
Corinna

Anonymous
Sun 15 Jan 2023 01:34:50 PM UTC, original submission:  

Hi,

I'm the maintainer of Cygwin and, incidentally, also the
maintainer of the attr package in the Cygwin distro.

The attr package is part of Cygwin for quite some time, but
I never got around to submit the Cygwin-specific patches
upstream.  This bug report is to make good for this negligence.

The latest package in the Cygwin distro was attr-2.4.48.
When trying to build 2.5.1 for Cygwin, I found that
libattr/syscalls.c had changed in a way incompatible with
Cygwin.  Fortunately, the post-2.5.1 commit 7b3423dcbf67
fixed that for us.

The only change required now for Cygwin against git master is
a tweak to the Makefile expression building the libattr shared
library.

Patch attached.  I hope it's ok to go upstream.


Thanks,
Corinna
(vinschen AT redhat DOT com)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #54227:  0001-Add-Cygwin-support.patch added by None (2KiB - text/x-patch - Patch to support Cygwin, against git master)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by vapier (Updated the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-01-13 vapier StatusNone Fixed
        Open/ClosedOpen Closed
    2023-01-15 None Attached File- Added 0001-Add-Cygwin-support.patch, #54227

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code