bugGNU Octave - Bugs: bug #65658, bytecode-interpreter creating dist...

 
 

bug #65658: bytecode-interpreter creating dist file failure due to typo in module.mk

Submitter:  Philip Nienhuis <philipnienhuis>
Submitted:  Mon 29 Apr 2024 11:51:09 AM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Philip Nienhuis Open/Closed:  * Closed
Release:  * bytecode-evaluator Operating System:  * Any
Fixed Release:  10.1.0 (current default) Planned Release:  10.1.0 (current default)
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 15 May 2024 05:18:43 PM UTC, comment #4: 

Builds fine. Closing report.

Philip Nienhuis <philipnienhuis>
Group Member
Mon 13 May 2024 06:38:17 PM UTC, comment #3: 


> I couldn't download the patch from this report. (Some savannah error. Maybe caused by the hashes `#` in the file name?)

Sounds familiar, I couldn't either. Another lesson learned, no hashes in file names. Which interferes a bit with the usual naming habit here where we usually prepend bug numbers with a hash, TTBOMK also in file names.

> I still don't know why the `install` error didn't propagate to the parent `make install`

Maybe 'make dist' (which triggered this bug report) is more picky?

Thanks for pushing 'a' fix. Luckily arb's one was better shaped for Savannah :-)

Philip Nienhuis <philipnienhuis>
Group Member
Mon 13 May 2024 09:40:56 AM UTC, comment #2: 

I couldn't download the patch from this report. (Some savannah error. Maybe caused by the hashes `#` in the file name?)

@arb: I pushed the change you proposed in bug #65731 to the bytecode-interpreter branch:
https://hg.savannah.gnu.org/hgweb/octave/rev/80346999b171

I still don't know why the `install` error didn't propagate to the parent `make install`. `make install` probably should have failed in CI before this change. (But it didn't.)

Marking as ready for test anyway.

Markus Mützel <mmuetzel>
Group administrator
Fri 03 May 2024 08:53:43 AM UTC, comment #1: 


> AFAIK the bytecode-interpreter branch isn´t regularly built for Windows


The bytecode-interpreter branch is built and the test suite is run (plus a few additional tests) on each commit to the bytecode-interpreter branch on Ubuntu, Alpine, macOS, and Windows. E.g., from 2 hours ago:
https://github.com/gnu-octave/octave/actions/runs/8934818134

However, all of these builds are native and do not require creating a tarball.
It might be worth adding a step to the CI to create that tarball just to make sure it doesn't break (at least on one of the platforms - probably best on Ubuntu).

Markus Mützel <mmuetzel>
Group administrator
Mon 29 Apr 2024 11:51:09 AM UTC, original submission:  

Creating a dist file for the bytecode-interpreter branch of 10.0.0 fails with:

:
if test -d "octave-10.0.0"; then find "octave-10.0.0" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "octave-10.0.0" || { sleep 5 && rm -rf "octave-10.0.0"; }; else :; fi
test -d "octave-10.0.0" || mkdir "octave-10.0.0"
 (cd libgnu && make  top_distdir=../octave-10.0.0 distdir=../octave-10.0.0/libgnu \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory '/home/philip/devel/octdev/oct1000+/libgnu'
make  distdir-am
make[4]: Entering directory '/home/philip/devel/octdev/oct1000+/libgnu'
make[4]: Leaving directory '/home/philip/devel/octdev/oct1000+/libgnu'
make[3]: Leaving directory '/home/philip/devel/octdev/oct1000+/libgnu'
 (cd test && make  top_distdir=../octave-10.0.0 distdir=../octave-10.0.0/test \
     am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory '/home/philip/devel/octdev/oct1000+/test'
make  distdir-am
make[4]: Entering directory '/home/philip/devel/octdev/oct1000+/test'
make[4]: *** No rule to make target '../../dev_p/test/compile/shutup_operator_test/@double/display.m', needed by 'distdir-am'.  Stop.
:

WIP patch attached. Feel free to amend commit message and bug number.
It's an add-on to cset ea29311fbd44 bytecode-interpreter 'rename some files for consistency' by JWE from Apr. 16.

BTW this is one of those corner cases slipping through because AFAIK the bytecode-interpreter branch receives little testing. Dist archives are probably only required for mxe-octave and AFAIK the bytecode-interpreter branch isn´t regularly built for Windows (let alone used in practice) except maybe by me :-)
Or am I mistaken?


Philip Nienhuis <philipnienhuis>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-05-15 philipnienhuis StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2024-05-13 mmuetzel StatusPatch Submitted Ready For Test
        Releasedev bytecode-evaluator
        Carbon-Copy- Added arb
    2024-05-13 mmuetzel Dependencies- bugs #65731 is dependent
    2024-04-29 philipnienhuis Attached File- Added bug_######_BI_test-compile-module.mk.patch, #55988

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code