bugmonotone - Bugs: bug #21171, 'list unknown' command fails with...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #21171: 'list unknown' command fails with '\' on filenames

Submitter:  Zack Weinberg <zackw>
Submitted:  Thu 27 Sep 2007 06:14:16 PM UTC
   
 
Category:  working copy Severity:  3 - Normal
Item Group:  crash Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
mtn version --full: 

monotone 0.36 (base revision: e4bc808d89e029ce623f9e8f2b10c84006b83fb5)
Running on          : Linux 2.6.18-5-k7 #1 SMP Thu Aug 30 02:52:31 UTC 2007 i686
C++ compiler        : GNU C++ version 4.1.2 20061115 (prerelease) (Debian 4.1.1-21)
C++ standard library: GNU libstdc++ version 20061115
Boost version       : 1_33_1
Changes since base revision:
format_version "1"

new_manifest [87e344675f9dd7758eb68b2a01516c552307591c]

old_revision [e4bc808d89e029ce623f9e8f2b10c84006b83fb5]

 Generated from data cached in the distribution;
 further changes may have been made.

Thu 14 Jan 2010 09:02:56 AM UTC, comment #5: 

This has been fixed in 0.45 and onwards. Paths with invalid characters are now simply ignored and a warning is spit out.

Thomas Keller <tommyd>
Group administrator
  Spam posted by anonymous
Tue 18 Dec 2007 11:41:04 PM UTC, comment #3: 

<rant>As a side note, it remains unclear to me why a node name cannot contain a backslash in its name. Why should I care that I can't checkout my project on certain non-unix systems?</rant>

Thomas Moschny <moschny>
Group administrator
Thu 27 Sep 2007 08:40:21 PM UTC, comment #2: 


>Second, it shouldn't be an error, as long as you don't try to check that file in. That means operations that deal with all the files in the WC need to be prepared to handle arbitrary filenames, and that's going to be much harder (we'll, at the least, need yet another *_path type).


Alternatively, we could just hard-filter them out at a low level, i.e. notice that the filename is screwy and simply don't pass it on to higher-level logic (possibly printing a warning in the process).

This means that 'ls unknown', 'ls ignored', and 'automate inventory' would fail to mention these particular weird files, but I don't know if anyone would care in practice.

Nathaniel Smith <njs>
Group Member
Thu 27 Sep 2007 06:21:25 PM UTC, comment #1: 

The problem here is twofold.  First, we should not be considering it an invariant failure if a file in the working copy has a name that violates the name restrictions; it should be easy to make it into an E() or N() condition instead.

Second, it shouldn't be an error, as long as you don't try to check that file in.  That means operations that deal with all the files in the WC need to be prepared to handle arbitrary filenames, and that's going to be much harder (we'll, at the least, need yet another *_path type).

Zack Weinberg <zackw>
Thu 27 Sep 2007 06:14:16 PM UTC, original submission:  

$ touch \\
$ mtn list unknown
mtn: fatal: std::logic_error: paths.cc:415: invariant 'I(utf8_validate(utf8(data)) && !has_bad_component_chars(data) && data != "." && data != "..")' violated
mtn: this is almost certainly a bug in monotone.
[...]
$ rm \\
$ mtn list unknown
backup/mysql.dump.20070926
log/access.log
log/error.log

Originally reported as Debian bug #444153, <http://bugs.debian.org/444153>.

Zack Weinberg <zackw>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by tommyd (Posted a comment)
  • -email is unavailable- added by moschny (Posted a comment)
  • -email is unavailable- added by njs (Posted a comment)
  • -email is unavailable- added by zackw
  • -email is unavailable- added by zackw (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-01-14 tommyd StatusNone Fixed
        Open/ClosedOpen Closed
        Summary\'list unknown\' command fails with \'\\\' on filenames 'list unknown' command fails with '\' on filenames
    2007-12-18 moschny Summary\'list unknown\' command fails with \'\\\' on filenames 'list unknown' command fails with '\' on filenames
    2007-09-27 njs Summary\'list unknown\' command fails with \'\\\' on filenames 'list unknown' command fails with '\' on filenames
    2007-09-27 zackw Carbon-Copy- Added vlad shakhov <v.shakhov@velesys.com>

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code