bugmonotone - Bugs: bug #21870, "mtn status" prints...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #21870: "mtn status" prints garbled characters.

Submitter:  None
Submitted:  Sat 22 Dec 2007 09:26:38 AM UTC
 
Category:  charset handling Severity:  3 - Normal
Item Group:  incorrect behavior Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
mtn version --full: 

monotone 0.38 (base revision: c1757f6cde49bddd77c82580059105bc470145b2)
Running on          : FreeBSD 6.2-RELEASE-p4 FreeBSD 6.2-RELEASE-p4 #0: Thu Apr 26 17:40:53 UTC 2007     root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386
C++ compiler        : GNU C++ version 3.4.6 [FreeBSD] 20060305
C++ standard library: GNU libstdc++ version 20060311
Boost version       : 1_34_1
Changes since base revision:
format_version "1"

new_manifest [085f4d04a0bbbc06b44cf6194ca9c2079f924cdd]

old_revision [c1757f6cde49bddd77c82580059105bc470145b2]

  Generated from data cached in the distribution;
  further changes may have been made.

Wed 07 Jan 2009 02:09:49 AM UTC, comment #1: 

The issue was further discussed here, but not yet fixed:

http://thread.gmane.org/gmane.comp.version-control.monotone.devel/14884/focus=14884

Thomas Keller <tommyd>
Project Administrator
Sat 22 Dec 2007 09:26:38 AM UTC, original submission:  

Dear the development team of monotone,

Not in the C locale, "mtn status" shows garbled characters.

I guess, in the function "revision_summary" of the file cmd_ws_commit.cc, you create the instance of utf8 class with the constructor, but the argument string is encoded in user's locale, not in UTF-8. Because F() returns what gettext() returns.

static void
revision_summary(revision_t const & rev, branch_name const & branch, utf8 & summary)
{
  string out;
...
  out += (F("Current branch: %s") % branch).str() += '\n';
...
    summary = utf8(out);
}

I attach a sample fix.

Regards,
Tomohisa Tanaka (Tomohisa.Tanaka@gmail.com)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #14682:  monotone-status-sample-fix.patch added by None (2KiB - application/octet-stream - My sample fix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by tommyd (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-12-22 None Attached File- Added monotone-status-sample-fix.patch, #14682

    Back to the top


    Powered by Savane 3.9