bugAdonthell - Bugs: bug #25737, Adonthell doesn't build with GCC...

 
 

bug #25737: Adonthell doesn't build with GCC 4.4

Submitter:  Mathieu Bridon <bochecha>
Submitted:  Sun 01 Mar 2009 11:58:04 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  ksterker
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 11 May 2009 07:33:51 PM UTC, comment #3: 

Updated v0.4 to compile with GCC 4.4 as well

Kai Sterker <ksterker>
Group administrator
Sun 01 Mar 2009 12:31:23 PM UTC, comment #2: 

Thanks for being so quick ! :)

Did you release a 0.3.6 with this fix or is it only in CVS right now ?

If so, could you attach a patch so that I can use it in the Fedora 11 RPM while waiting for next release ?

Mathieu Bridon <bochecha>
Sun 01 Mar 2009 12:26:31 PM UTC, comment #1: 

I fixed the issue in dialog.cc (for both 0.3 and 0.4). Thanks for the report.

As for all the deprecation warnings, they are on the radar and I intend to fix them some day, but it will probably take a while.

I'll leave this bug open for now, in case more issues come up.

Kai

Kai Sterker <ksterker>
Group administrator
Sun 01 Mar 2009 11:58:04 AM UTC, original submission:  

Fedora 11 is moving to GCC 4.4.

I tried to build Adonthell on it, but it fails.

Full error log is here:
http://koji.fedoraproject.org/koji/getfile?taskID=1149702&name=build.log

The interesting part (apart from all the warning on deprecated headers) is:
dialog.cc: In member function 'std::string dialog::scan_string(const char*)':
dialog.cc:276: error: invalid conversion from 'const char*' to 'char*'
dialog.cc:328: error: invalid conversion from 'const char*' to 'char*'

I tried defining the "start" var as a "const char " instead of a "char " and it pleased the compiler on those 2 errors, however, it then failed on line 322:
dialog.cc: In member function 'std::string dialog::scan_string(const char*)':
dialog.cc:322: error: assignment of read-only location '* start'

So obviously, it's gonna be a little more complicated than that.

Mathieu Bridon <bochecha>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ksterker (Posted a comment)
  • -email is unavailable- added by bochecha (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-05-11 ksterker StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2009-03-01 ksterker Assigned toNone ksterker
    2009-03-01 ksterker StatusNone In Progress

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code