bugLinterna Mágica - Bugs: bug #34465, Part of the HD links list is not...

 
 

bug #34465: Part of the HD links list is not visible in YouTube

Submitted by:  Ivaylo Valkov <valkov>
Submitted on:  Mon Oct 3 06:35:30 2011  
 
Category: Interface bugSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Ivaylo Valkov <valkov>
Open/Closed: ClosedRelease: git-master

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon Dec 5 18:32:42 2011, comment #8:

The last fix looks stable, so I'm closing this bug. If the HD list menu still does not behave as expected, or new bugs were introduced, please reopen it.

Ivaylo Valkov <valkov>
Project AdministratorIn charge of this item.
Tue Nov 29 13:28:03 2011, comment #7:

The changes in r223 are another attempt to fix this issue. Changes in r217 do not behave well with resolutions equal to or lower than 1024x768.

The HD links button and list were moved to the controls footer. The HD list is rendered at the right. Special care was taken for RTL pages and possible future LM translations for RTL languages. With RTL buttons ordering is from right to left. This way the HD list renders at the visible part of the screen at the left with RTL in YouTube. Should behave the same in other RTL pages.

Seems there are not issues with this fix.

One possible bug will be unavailable HD button and list, if someone turns off the web buttons and uses the ones of the video plugin.

(file #24493, file #24494)

Ivaylo Valkov <valkov>
Project AdministratorIn charge of this item.
Sat Nov 26 11:51:31 2011, comment #6:

Partially ported to branch 0.0.10 for the 0.0.10-2 release in revision 217. Code snippets from revision 208.

When the HD list does not fit in the space between the LM header and the top of the window, its height is fixed and the "overflow-y" CSS rule is set to scroll. This is a temporary fix for the 0.0.10 branch only.

Ivaylo Valkov <valkov>
Project AdministratorIn charge of this item.
Fri Nov 25 14:19:35 2011, comment #5:

Revision r214 should be the last commit that tries to fix this bug.

Shorter labels for links. All the information is showed in a hint/tooltip. The list renders at the left of the video player.

Works with RTL languages in YouTube.

The attached file is a demonstration of how the menu renders.

(file #24451)

Ivaylo Valkov <valkov>
Project AdministratorIn charge of this item.
Fri Nov 25 10:35:10 2011, comment #4:

Added some changes in
revision 211. Hard coded the height of the div that holds the HD list. Added proper calculation for the width of the holder div. It seems this behaves as it should. The list is still above the player.

Ivaylo Valkov <valkov>
Project AdministratorIn charge of this item.
Fri Nov 25 09:05:33 2011, comment #3:

After the last commit the list does not behave as it should be. I have a fix in my working copy, that kind of fixes some flaws in the logic.

While investigating Bug #34891 I've enabled the new 3D HD links YouTube had introduced. This makes the list even larger. It is obvious that the list at the top is not working well with more and more links.

The idea is to move it at the right of the player when predefined number of links in the list is reached.

The current work-around is useful in some situations and number of links, but I think I will remove it. Supporting three types of menu is not a good idea.

The attached images show what I mean.

Any suggestions or comments?

(file #24448, file #24449)

Ivaylo Valkov <valkov>
Project AdministratorIn charge of this item.
Thu Nov 24 16:14:24 2011, comment #2:

More fixes in revision 210. Set hard coded width for li elements. Fixes displacement in tabular view. Updated build at the website. Use direct link, mirrors will be updated after 24h.

Ivaylo Valkov <valkov>
Project AdministratorIn charge of this item.
Mon Oct 10 12:29:35 2011, comment #1:

Working code in revision 208.

Ivaylo Valkov <valkov>
Project AdministratorIn charge of this item.
Mon Oct 3 06:35:30 2011, original submission:

When the space from the top of the screen to the header element of Linterna Mágica is less than the one needed for the HD links list, some links are not visible. This is observed only in YouTube.

The proposed solution is to calculate the space from the top of the window to the header element. Then if/when needed to limit the HD links list height and increase width. Using "float:left" for links might help as well. This way the list will render in two (or more) columns.

Ivaylo Valkov <valkov>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #24493:  lm-controls-ltr.png added by valkov (17kB - image/png - New layout of the controls footer and HD list rendering.)
file #24494:  lm-controls-rtl.png added by valkov (23kB - image/png - New layout of the controls footer and HD list rendering.)
file #24451:  lm-hd-list-fixed.png added by valkov (19kB - image/png)
file #24448:  lm-hd-list-large.png added by valkov (163kB - image/png)
file #24449:  lm-hd-list-mockup.png added by valkov (107kB - image/png)
file #24088:  screenshot6.png added by valkov (44kB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by valkov (Submitted the item)
  • -unavailable- added by valkov (The HD list bug in YouTube now has a bug report)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Dec 5 18:32:42 2011valkovStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue Nov 29 13:28:03 2011valkovAttached File-=>Added lm-controls-ltr.png, #24493
      Attached File-=>Added lm-controls-rtl.png, #24494
    Fri Nov 25 14:19:35 2011valkovAttached File-=>Added lm-hd-list-fixed.png, #24451
    Fri Nov 25 09:05:33 2011valkovAttached File-=>Added lm-hd-list-large.png, #24448
      Attached File-=>Added lm-hd-list-mockup.png, #24449
    Mon Oct 10 12:29:35 2011valkovStatusIn Progress=>Ready For Test
    Sun Oct 9 15:46:12 2011valkovStatusConfirmed=>In Progress
    Mon Oct 3 06:35:30 2011valkovAttached File-=>Added screenshot6.png, #24088
      Carbon-Copy-=>Added katsarov

    Back to the top


    Powered by Savane 3.1-cleanup1