bugLinterna Mágica - Bugs: bug #34465, Part of the HD links list is not...

 
 

bug #34465: Part of the HD links list is not visible in YouTube

Submitter:  Ivaylo Valkov <valkov>
Submitted:  Mon 03 Oct 2011 06:35:30 AM UTC
   
 
Category:  Interface bug Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  valkov
Open/Closed:  Closed Release:  git-master
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 05 Dec 2011 06:32:42 PM UTC, comment #8: 

The last fix looks stable, so I'm closing this bug. If the HD list menu still does not behave as expected, or new bugs were introduced, please reopen it.

Ivaylo Valkov <valkov>
Group administrator
Tue 29 Nov 2011 01:28:03 PM UTC, comment #7: 

The changes in r223 are another attempt to fix this issue. Changes in r217 do not behave well with resolutions equal to or lower than 1024x768.

The HD links button and list were moved to the controls footer. The HD list is rendered at the right. Special care was taken for RTL pages and possible future LM translations for RTL languages. With RTL buttons ordering is from right to left. This way the HD list renders at the visible part of the screen at the left with RTL in YouTube. Should behave the same in other RTL pages.

Seems there are not issues with this fix.

One possible bug will be unavailable HD button and list, if someone turns off the web buttons and uses the ones of the video plugin.


Ivaylo Valkov <valkov>
Group administrator
Sat 26 Nov 2011 11:51:31 AM UTC, comment #6: 

Partially ported to branch 0.0.10 for the 0.0.10-2 release in revision 217. Code snippets from revision 208.

When the HD list does not fit in the space between the LM header and the top of the window, its height is fixed and the "overflow-y" CSS rule is set to scroll. This is a temporary fix for the 0.0.10 branch only.

Ivaylo Valkov <valkov>
Group administrator
Fri 25 Nov 2011 02:19:35 PM UTC, comment #5: 

Revision r214 should be the last commit that tries to fix this bug.

Shorter labels for links. All the information is showed in a hint/tooltip. The list renders at the left of the video player.

Works with RTL languages in YouTube.

The attached file is a demonstration of how the menu renders.


Ivaylo Valkov <valkov>
Group administrator
Fri 25 Nov 2011 10:35:10 AM UTC, comment #4: 

Added some changes in
revision 211. Hard coded the height of the div that holds the HD list. Added proper calculation for the width of the holder div. It seems this behaves as it should. The list is still above the player.

Ivaylo Valkov <valkov>
Group administrator
Fri 25 Nov 2011 09:05:33 AM UTC, comment #3: 

After the last commit the list does not behave as it should be. I have a fix in my working copy, that kind of fixes some flaws in the logic.

While investigating Bug #34891 I've enabled the new 3D HD links YouTube had introduced. This makes the list even larger. It is obvious that the list at the top is not working well with more and more links.

The idea is to move it at the right of the player when predefined number of links in the list is reached.

The current work-around is useful in some situations and number of links, but I think I will remove it. Supporting three types of menu is not a good idea.

The attached images show what I mean.

Any suggestions or comments?


Ivaylo Valkov <valkov>
Group administrator
Thu 24 Nov 2011 04:14:24 PM UTC, comment #2: 

More fixes in revision 210. Set hard coded width for li elements. Fixes displacement in tabular view. Updated build at the website. Use direct link, mirrors will be updated after 24h.

Ivaylo Valkov <valkov>
Group administrator
Mon 10 Oct 2011 12:29:35 PM UTC, comment #1: 

Working code in revision 208.

Ivaylo Valkov <valkov>
Group administrator
Mon 03 Oct 2011 06:35:30 AM UTC, original submission:  

When the space from the top of the screen to the header element of Linterna Mágica is less than the one needed for the HD links list, some links are not visible. This is observed only in YouTube.

The proposed solution is to calculate the space from the top of the window to the header element. Then if/when needed to limit the HD links list height and increase width.  Using "float:left" for links might help as well. This way the list will render in two  (or more) columns.

Ivaylo Valkov <valkov>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #24493:  lm-controls-ltr.png added by valkov (17KiB - image/png - New layout of the controls footer and HD list rendering.)
file #24494:  lm-controls-rtl.png added by valkov (23KiB - image/png - New layout of the controls footer and HD list rendering.)
file #24451:  lm-hd-list-fixed.png added by valkov (19KiB - image/png)
file #24448:  lm-hd-list-large.png added by valkov (163KiB - image/png)
file #24449:  lm-hd-list-mockup.png added by valkov (107KiB - image/png)
file #24088:  screenshot6.png added by valkov (44KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by valkov (Submitted the item)
  • -email is unavailable- added by valkov (The HD list bug in YouTube now has a bug report)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-12-05 valkov StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2011-11-29 valkov Attached File- Added lm-controls-ltr.png, #24493
        Attached File- Added lm-controls-rtl.png, #24494
    2011-11-25 valkov Attached File- Added lm-hd-list-fixed.png, #24451
    2011-11-25 valkov Attached File- Added lm-hd-list-large.png, #24448
        Attached File- Added lm-hd-list-mockup.png, #24449
    2011-10-10 valkov StatusIn Progress Ready For Test
    2011-10-09 valkov StatusConfirmed In Progress
    2011-10-03 valkov Attached File- Added screenshot6.png, #24088
        Carbon-Copy- Added katsarov

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code