bugLinterna Mágica - Bugs: bug #35996, Linterna Mágica is not working...

 
 

bug #35996: Linterna Mágica is not working with Scriptish

Submitted by:  Ivaylo Valkov <valkov>
Submitted on:  Sun Mar 25 14:41:52 2012  
 
Category: Feature requestSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Ivaylo Valkov <valkov>
Open/Closed: ClosedRelease: git-master

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri Apr 27 14:20:46 2012, comment #6:

Fixed! Will be in the next stable (bug-fix or major) release.

Ivaylo Valkov <valkov>
Project AdministratorIn charge of this item.
Sat Apr 21 09:36:06 2012, comment #5:

From what I've found out I can conclude that Scriptish injects scripts differently than Greasemonkey. The code that injects Linterna Mágica in the scope of the page is based on a method [1] explained in the Greasemonkey wiki. The method works on the assumption that the userscript's code is executed inside a function and at run-time this function's body can be used to access the entire userscript. This is achieved by converting the caller function (the one that runs the userscript) to string - .caller.toString();. Scriptish breaks here and complains that the caller object is non-existent.

The work-around is to wrap the userscript inside an anonymous self invoking function - (function() { ... })();. This way the injection code works.

A working code is available in r271. The svn trunk build at the website is now at that revision, but mirrors update at 24 hours, so until then use the direct link. So far the code seems working, but just in case I'm leaving it in testing phase. Please report any new issues with that revision. The Scriptish version tested was 0.1.7 on Abrowser 11.0.

[1] http://wiki.greasespot.net/Content_Scope_Runner

Ivaylo Valkov <valkov>
Project AdministratorIn charge of this item.
Thu Apr 12 09:59:23 2012, comment #4:

Not necessarily. I haven't got the time to fully investigate the issue. I might come up an work-around. If that fails, a question/bug report will be send to the developers of Scriptish, so they can comment on the injection of userscripts from within the sandbox context to web page context. I'll write a comment here when I have a little bit more information.

Ivaylo Valkov <valkov>
Project AdministratorIn charge of this item.
Thu Apr 12 09:41:45 2012, comment #3:

So, it depends on the Scriptish team to make it work with Linterna Magica, is that it?

libre fan <librefan1>
Mon Mar 26 16:11:05 2012, comment #2:

As I've written in the first message there is a problem with the injection code that makes Linterna Mágica run in the web page scope. I had no time to investigate it in depth, but it had something to do with syntax and context errors in the JavaScript code when run within Scriptish. It might be a change in Scriptish that causes this. Of course, it might be a change in Linterna Mágica, but the last change in the part of the code mentioned was in r203 at 28th of September 2011. The injection code was first added in r46 at 26th of April 2011, because of problems with Firefox 4 and above when running in the Greasemonkey sandboxed context.

Ivaylo Valkov <valkov>
Project AdministratorIn charge of this item.
Mon Mar 26 08:46:58 2012, comment #1:

Linterna Magica used to work fine with Scriptish and Abrowser or Firefox beta in Trisquel 5.

Now, Linterna Magica works fine with Greasemonkey and Firefox beta (12) with gecko-mediaplayer as a plugin on Debian wheezy (testing).

libre fan <librefan1>
Sun Mar 25 14:41:52 2012, original submission:

Linterna Mágica is not working wit the Scriptish [1] extension that is meant as a replacement for Greasemonkey.

The code that injects the script in the page breaks when it is run from Scriptish.

Scriptish is free software released under MIT license, [2] so it is not a problem to fix this.

[1] http://scriptish.org/
[2] https://github.com/scriptish/scriptish/blob/master/LICENSE.txt

[3] http://trisquel.info/en/forum/anonymox-and-linterna-magica#comment-18278

Ivaylo Valkov <valkov>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by librefan1 (Posted a comment)
  • -unavailable- added by valkov (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri Apr 27 14:20:46 2012valkovStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat Apr 21 09:36:06 2012valkovStatusNeed Info=>Ready For Test

    Back to the top


    Powered by Savane 3.1-cleanup1