The FreeType Project - Bugs: bug #53816, Make target_include_directories...
You are not allowed to post comments on this tracker with your current authentication level.
bug #53816: Make target_include_directories PUBLIC
Submitter: | Steve Robinson <ssrobins> | ||
Submitted: | Thu 03 May 2018 01:38:08 AM UTC | ||
Severity: | 3 - Normal | Item Group: | None |
Status: | Fixed | Privacy: | Public |
Assigned to: | morksig | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Tue 08 May 2018 05:15:21 AM UTC, comment #6: |
Steve Robinson <ssrobins> |
Mon 07 May 2018 10:13:22 PM UTC, comment #5: Actually, can you try https://github.com/madig/freetype2/tree/cmake-fix-project-inclusion and see if it does what you need?
What I mean is something like
|
Nikolaus Waxweiler <morksig> |
Fri 04 May 2018 12:17:46 AM UTC, comment #4: I guess I don't need it personally because I'm extracting the freetype source tar and building in the CMAKE_CURRENT_BINARY_DIR, but if those are public headers, then others will. More details on my build setup here:
|
Steve Robinson <ssrobins> |
Thu 03 May 2018 11:45:06 AM UTC, comment #3: Uh... I suppose you'd need
|
Nikolaus Waxweiler <morksig> |
Thu 03 May 2018 04:51:01 AM UTC, comment #2: I've fixed the title and assigned it to Nikolaus. |
Werner LEMBERG <wl> |
Thu 03 May 2018 01:39:44 AM UTC, comment #1: Sorry I somehow screwed up the bug title. It should be, "Make target_include_directories PUBLIC" |
Steve Robinson <ssrobins> |
Thu 03 May 2018 01:38:08 AM UTC, original submission:
In Freetype 2.9.1, CMakeLists.txt has code to privately set the include directory:
|
Steve Robinson <ssrobins> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-05-09 | morksig | Status | None | Fixed | |
Open/Closed | Open | Closed | |||
2018-05-03 | wl | Assigned to | None | morksig | |
Summary | Make | Make target_include_directories PUBLIC |
Powered by Savane 3.13-bb6a.
Corresponding source code
I added your edited CMakeLists.txt file into my build system and freetype built fine on Windows, Linux, and Mac. Thanks for working on that :)
find_package only works like magic if you have the library already built. For small libraries, I prefer to untar the source, use the add_subdirectory command to add it into my project and directly use all the CMake target information to build my program. That way, it's really easy to upgrade and build on many platforms, but the library isn't mixed in with my project source.
I suppose I could use Conan Package manager, but last I checked there weren't many libraries officially supported and I haven't had the time to help out.