bugXlog - Bugs: bug #60004, xlog 2.0.20 fails to build under...

 
 

bug #60004: xlog 2.0.20 fails to build under clang

Submitter:  Greg Troxel <gdt>
Submitted:  Thu 04 Feb 2021 07:43:36 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  andystewart
Open/Closed:  Closed Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 17 Feb 2021 07:49:07 PM UTC, comment #4: 


Greg says its good....closing.  Thanks, Greg!

Andy Stewart <andystewart>
Group administrator
Wed 17 Feb 2021 03:38:05 PM UTC, comment #3: 

I removed all my accomodations (adding -Wno-error for specific warnings) and still got a clean build.  I think you have removed the unnecessary double parens, and am guessing you resolved the maybe-uninitialized warning by making it more obvious that the variable was initialized, and dropped the pragma to suppress it.

I do still see a pragma about stringop truncation in logfile, and I think that might lead to a warning about unknown warnings in some places, but things are I think ok under clang now.   So probably best to close this bug and Ill start fresh with anything else I find.

Greg Troxel <gdt>
Wed 17 Feb 2021 02:01:33 AM UTC, comment #2: 


I've released these changes in xlog-2.0.21beta2.  Greg: can you test these and report your findings?  Thanks!

Andy Stewart <andystewart>
Group administrator
Mon 15 Feb 2021 10:45:41 PM UTC, comment #1: 

Hi Greg,

Thanks for bringing this to my attention.  I've fixed these things and the changes will be available in xlog 2.0.21.  Thanks for letting me know!

73,

Andy
KB1OIQ

Andy Stewart <andystewart>
Group administrator
Thu 04 Feb 2021 07:43:36 PM UTC, original submission:  

Building under macOS 10.13 (probably not relevant) with clang (probably very relevant :-), xlog 2.0.20 has a few warnings, which are fatal thanks to -Werror.

Lots of them are "if ((a == b))" with extra parens, which seems easy to change, unless it's some macro thing.

I've attached the output of "make -k" after a previous "make -k", so this is only the failing files.

Greg Troxel <gdt>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #50838:  XLOG added by gdt (9KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by andystewart (Posted a comment)
  • -email is unavailable- added by gdt (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-02-17 andystewart StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2021-02-17 andystewart StatusFixed Ready For Test
    2021-02-15 andystewart StatusNone Fixed
        Assigned toNone andystewart
    2021-02-04 gdt Attached File- Added XLOG, #50838

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code