lwIP - A Lightweight TCP/IP stack - Bugs: bug #35874, reserved identifier violation
You are not allowed to post comments on this tracker with your current authentication level.
bug #35874: reserved identifier violation
Submitter: | Markus Elfring <elfring> | ||
Submitted: | Sat 17 Mar 2012 02:40:19 PM UTC | ||
Category: | None | Severity: | 3 - Normal |
Item Group: | Change Request | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | 1.4.0 |
Jump to the original submission
Thu 22 May 2014 08:30:43 AM UTC, comment #11: |
Markus Elfring <elfring> |
Tue 20 May 2014 10:32:24 AM UTC, comment #10: Fixed again (changed H_ to _H).
|
Simon Goldschmidt <goldsimon> |
Tue 20 May 2014 10:23:57 AM UTC, comment #9:
|
Simon Goldschmidt <goldsimon> |
Mon 19 May 2014 09:10:35 PM UTC, comment #8:
http://git.savannah.gnu.org/cgit/lwip.git/commit/?id=dbd125c714f27254991cf85fa6a5a3626d2650fa
|
Markus Elfring <elfring> |
Mon 19 May 2014 08:26:32 PM UTC, comment #7:
|
Simon Goldschmidt <goldsimon> |
Mon 19 May 2014 08:12:51 PM UTC, comment #6: A little late here but without underscores there's a risk of colliding with user's names with this change that could impact existing code. I myself use LWIP_xxxx for my own LWIP defines.
|
Bill Auerbach <billauerbach> |
Mon 19 May 2014 07:59:35 PM UTC, comment #5: Done. Hope I caught them all... |
Simon Goldschmidt <goldsimon> |
Tue 27 Mar 2012 05:51:39 PM UTC, comment #4: Being like that, I'd target this for 1.5.0 (not that high prio to me, or did you have actual problems with the identifiers as they are now?).
|
Simon Goldschmidt <goldsimon> |
Sun 18 Mar 2012 09:15:38 PM UTC, comment #3: Re Simon's comment about C++ and C99 standards, it is worth pointing out that identifiers beginning with double underscore or underscore followed by an uppercase letter are also reserved by the ANSI/ISO C-1990 standard (see section 7.1.3), which is the basis of most embedded C compilers. This is not a new restriction in C99.
|
David Empson <dempson> |
Sun 18 Mar 2012 04:53:44 PM UTC, comment #2: Would you like to integrate the appended adjustments into your source code repository? |
Markus Elfring <elfring> |
Sun 18 Mar 2012 12:33:48 PM UTC, comment #1: I don't really know if the cited standards (C++, C99) apply to us as lwIP does not use C++ and most embedded compilers no nothing about C99, however, I guess it wouldn't hurt to change these identifiers...
|
Simon Goldschmidt <goldsimon> |
Sat 17 Mar 2012 02:40:19 PM UTC, original submission:
I suggest to try the search pattern "\<_(?:(?:_(.*))|([A-Z]+))" on source files.
|
Markus Elfring <elfring> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 10 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2014-05-20 | goldsimon | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2014-05-20 | goldsimon | Status | Fixed | In Progress | |
Open/Closed | Closed | Open | |||
2014-05-19 | goldsimon | Status | None | Fixed | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2012-03-27 | goldsimon | Planned Release | 1.5.0 | ||
2012-03-18 | elfring | Attached File | - | Added 0001-Bug-35874-Make-a-configuration-symbol-standard-compl.patch, #25394 | |
Attached File | - | Added 0001-Bug-35874-Make-include-guards-standard-compliant.patch, #25395 |
Powered by Savane 3.13-02a9.
Corresponding source code
Thanks for your source code improvement.