DcHub: Hub software for Direct Connect - Patches: patch #2312, patch for bug 6475 - invalid $SR...
You are not allowed to post comments on this tracker with your current authentication level.
patch #2312: patch for bug 6475 - invalid $SR calls
Submitter: | Dirk Rieger <hhgoth> | ||
Submitted: | Wed 19 Nov 2003 08:41:37 AM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | None | Privacy: | Public |
Assigned to: | ericprev | Open/Closed: | Open |
Jump to the original submission
Sun 23 Nov 2003 12:38:57 PM UTC, comment #7: |
Dirk Rieger <hhgoth> |
Sat 22 Nov 2003 11:02:05 AM UTC, comment #6: however - the problem has to be fixed for this and all other events this may occur as well, or we'll run into errors we can't handle without massive problems
|
Dirk Rieger <hhgoth> |
Sat 22 Nov 2003 08:48:53 AM UTC, comment #5: char * or gstring must be free. I suspect something inside GLUS_SEND_TO_A_NICK to release the allocated memory too early. IMHO, the problem should come from perl support. I think when perl functions return, they free the memory. If there is no other plugins (perl/python or plugin), everything works fine but if a plugin uses this memory later... boom. |
Eric PREVOTEAU <ericprev> |
Thu 20 Nov 2003 06:57:48 PM UTC, comment #4: if freeing is impossible may it would be better to use an GString instead...
|
Dirk Rieger <hhgoth> |
Thu 20 Nov 2003 06:47:16 PM UTC, comment #3: org_dup is a char no gstring - but put an free later on if you like ;)
|
Dirk Rieger <hhgoth> |
Thu 20 Nov 2003 06:32:20 PM UTC, comment #2: you should have a memory leak because org_dup memory is not released no ? |
Eric PREVOTEAU <ericprev> |
Wed 19 Nov 2003 09:13:50 AM UTC, comment #1: maybe other events have to be checked if such a fix has to be implemented there too. |
Dirk Rieger <hhgoth> |
Wed 19 Nov 2003 08:41:37 AM UTC, original submission:
The usage of the GString org after using the GLUS_SEND_TO_A_NICK doesn't seem to be 100% reliable. |
Dirk Rieger <hhgoth> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 2 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2003-11-23 | hhgoth | Patch Code | Modified - New Version | ||
2003-11-22 | ericprev | Assigned to | None | None |
Powered by Savane 3.13-02a9.
Corresponding source code
added - the missing 'free(org_dup)' to patch (memory-leak)
...to implement until the 'real' bug is found