Skencil - Patches: patch #3844, base patch
You are not allowed to post comments on this tracker with your current authentication level.
patch #3844: base patch
Submitter: | None | ||
Submitted: | Tue 22 Mar 2005 03:06:37 PM UTC | ||
Category: | 0.7.x | Priority: | 5 - Normal |
Status: | None | Privacy: | Public |
Assigned to: | None | Originator Email: | -email is unavailable- |
Open/Closed: | Open |
Sun 03 Apr 2005 08:16:41 PM UTC, comment #2: |
Bernhard Herzog <bh>![]() |
Wed 23 Mar 2005 05:45:23 PM UTC, comment #1: The patch was against an older cvs version. Sorry! This one should work. |
Anonymous |
Tue 22 Mar 2005 03:06:37 PM UTC, original submission:
This is ment to be a first patch in a series of patches breaking my recent changes to skencil 0.7 into smaller more digestable pieces. It provides many changes to the gui infrastructure and also some new dialogs. The most visibile change is the inspector panel which bundles the line, fill and property dialogs. Changes in the dialog are now immediately applied to the drawing. However, this can be switched off. The modal color dialog is replaced by a color panel which is inspired by Next Steps color chooser. Colors can now be transfered between most dialogs
|
Anonymous |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2005-03-23 | None | Attached File | - | ![]() |
Added base.patch_rev1, #4383 |
2005-03-22 | None | Attached File | - | ![]() |
Added base.patch, #4373 |
Carbon-Copy | - | ![]() |
Added ecker --AT-- physik --DOT-- hu-berlin --DOT-- de |
Thanks for splitting this up a little. However, this patch is still very big. Too big to be applied in one go. Would it be possible to split it up further?
I did look at the menu code a bit, though. Why is there a new file tmpmenu.py which contains large parts of menu.py? Wouldn't it have been better to simply put it all in to menu.py?
In tmpmenu, ListMenu doesn't seem to be used for anything except as a base class for Menu, so it would seem a bit clearer for now to merge these classes.
In tmpmenu, build_menu_tree checks whether description is an instance of MenuNode. AFAICT that is never the case. All callers always pass a sequence of (string or None) as the description.