patchmldonkey, a multi-networks file-sharing client - Patches: patch #4977, vd html progress bars


You are not allowed to post comments on this tracker with your current authentication level.

patch #4977: vd html progress bars

Submitter:  Dennis Nezic <dennisne>
Submitted:  Fri 17 Mar 2006 06:28:45 AM UTC
Category:  Improved interfaces Priority:  6
Status:  In Progress Assigned to:  None
Open/Closed:  Open

Jump to the original submission

Tue 24 Apr 2007 02:57:48 PM UTC, comment #11: 

I attached another patch that should take care of your personal CSS.

Daniel Schroeder <meto>
Mon 25 Sep 2006 10:41:45 PM UTC, comment #10: 

There is also the bar of file chunks (that shows which chunks are available, downloaded, etc); It too suffers from the same affliction -- it uses the background color of table cells to fill the bar.

The problem with my solution is that several colors are required here. Images are the only way to go in this case.

I'm playing again with the idea of using 1x1 images (embedded in css, or otherwise) to fill the cells instead. It can work except I don't think there is any way to programmatically define their colors. Using PPMs could be programmable, but I don't know of any browser that supports them :(.

Would anyone have a problem if this chunk-bar became a fixed color bar? Because, otherwise, I don't think there is any way for users like me to see it :(.

Dennis Nezic <dennisne>
Sat 12 Aug 2006 05:58:56 PM UTC, comment #9: 


I can confirm that your "new" progress bar works well in Opera and Firefox, but not in Elinks -- as you said.

Christian Schlotter <schlotter>
Fri 14 Jul 2006 03:48:50 AM UTC, comment #8: 

I've attached a sample.html with yet another way to implement the progress bar -- via the border of an empty DIV element. It will work when browsers force system colors -- but not in text browsers. It should also display better under Opera, etc.? Confirmation?

Regarding the HR implementation, I believe it was the font-size:1px (setting an absolute value for font-size) that confused Opera -- perhaps giving it a relative or percentage value could also work?

Dennis Nezic <dennisne>
Wed 12 Jul 2006 03:09:39 AM UTC, comment #7: 

Did I mention it's possible to view this patched progress bar in links, and other such text-based web browsers? :]

I really wish other browser users would help out a little (cough zet cough). How hard can it be to have a Hard Rule progress bar display the same in Opera/Konqueror as in Firefox :\

Dennis Nezic <dennisne>
Mon 12 Jun 2006 08:25:05 PM UTC, comment #6: 

Closed because of lack of updates to this patch.
If you would like to update it please drop a note,
i will re-open it.

spiralvoice <spiralvoice>
Group administrator
Mon 20 Mar 2006 12:56:39 AM UTC, comment #5: 

i don't mind not applying the patch as is, since there are minor issues with other browsers (i'm sure it's some small bit of non-fully-compliant css code), but, once they're resolved, i think it's a serious issue. i'm sure there are enough other people that surf the web as i do, for which the current interface is very hard to read.

and, on that note, i would really like users of the other browsers to point out what is causing the problem in rendering the bar. since i don't use them. i (naively) assumed that the css code i used was a standard.

Dennis Nezic <dennisne>
Fri 17 Mar 2006 07:15:57 PM UTC, comment #4: 

Try it in Opera as well.  All rows become too fat, and the colour of the bar is incorrect.

When making a major change like this you really must test IE, Opera, Mozilla and Konqueror to make sure there are no regressions.

z <zet>
Group Member
Fri 17 Mar 2006 06:53:06 PM UTC, comment #3: 

regarding making my own html_theme, i don't think i'd be able to replace the old table with my hard rule, since the table code is generated by mlnet -- and not, as far as i can see, by some html template. before i settled on the HR idea, i was playing around with having a 1x1 image (an embedded png in the SRC of an image tag), and then resizing that to the right percentage. this would surely produce the same results across all browsers (although i still think the HR method should as well) ... but it too would require a patch, and not just a tweaking of the css style. this should be the simplest, cleanest way to do it.

Dennis Nezic <dennisne>
Fri 17 Mar 2006 06:27:41 PM UTC, comment #2: 

people still use IE ? :(

how does it look there? what do you mean by "bad"? i thought HR was supposed to be a standard html object. maybe you can figure out what is making it look bad -- cuz it looks exactly the same here =\. maybe you can post a small screenshot of how it renders there?

and, on a side note, i think it "forcing own colors" should be the standard way of browsing the web. since when were we (the users) supposed to bow down to the (ugly) styling whims of web designers? content before design is my philosophy. also, having a standard color scheme across all pages really helps readability, i have found. :). enough preaching.

Dennis Nezic <dennisne>
Fri 17 Mar 2006 05:56:55 PM UTC, comment #1: 

This looks bad on IE, so it certainly does make a difference.

Your specialized use of "forcing own colors" is not standard, so it isn't really a target of mldonkey.  The current code has been tested and used for a long time across browsers.  If you want a custom look, you can create your own html_theme with its own CSS.

z <zet>
Group Member
Fri 17 Mar 2006 06:28:45 AM UTC, original submission:  

in mldonkey's web interface, a table with two cells was used to display download progress (with widths corresponding to the completed and remaining percentages). this patch simplifies the html by displaying progress as a single HR element, left aligned. effectively, it will look almost exactly as before, albeit the code will be cleaner.

BUT, the main purpose of this patch is to have the download progress bars displayable when users have their browsers set to force their own colors (ie, mine forces /all/ pages to have black backgrounds and gray text). unfortunately, this eliminates all background-color style elements (bgcolors, etc), which is what the previous table implementation was using (the bar was the background color of the table cell). so, without this patch, i cannot see the progress bar at all! using this method, the bar is an actual line, and displays fine :)

and, did i mention it cleans up the code? it also eliminates the color_vd_remaining style variable, which was pretty useless anyways, since it was pretty much always the background color (ie, effectively transparent).

for users who force their own colors, this patch is essential -- and for others, it makes no difference, besides simplifying the style a bit. actually, the /only/ display difference is that the bar is rendered with rounded edges here (in my firefox) ... which is a positive side-effect, i think, since if a style declares a larger bar size, it becomes nice and rounded -- very good looking (although, i prefer the small default of 2px).

Dennis Nezic <dennisne>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #12586:  vd_completion_and_chunk_bar_background.patch added by meto (994B - application/octet-stream - Another sollution with less changes)
file #10343:  sample.html added by dennisne (6KiB - text/html - Sample DIV implementation of the progress bar)
file #9662:  sshot_hr_in_firefox.jpg added by dennisne (39KiB - image/jpeg - how the HR renders in firefox, when user colors are forced)
file #9658:  vd_completion_bar_hr.patch added by dennisne (9KiB - application/octet-stream - replaces table with hr for download progress bar, applied against 2.7.4 release)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by meto (Updated the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-04-24 meto Attached File- Added vd_completion_and_chunk_bar_background.patch, #12586
    2006-07-14 dennisne Attached File- Added sample.html, #10343
    2006-07-12 spiralvoice StatusWont Do In Progress
        Open/ClosedClosed Open
    2006-06-12 spiralvoice Open/ClosedOpen Closed
    2006-03-19 spiralvoice StatusNone Wont Do
    2006-03-17 dennisne Attached File- Added sshot_hr_in_firefox.jpg, #6051
    2006-03-17 dennisne Attached File- Added vd_completion_bar_hr.patch, #6047

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code