patchTransport Sample Protocol - Patches: patch #5688, Fix building of RPM packages

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5688: Fix building of RPM packages

Submitter:  Robert de Vries <rhdv>
Submitted:  Mon 15 Jan 2007 12:58:49 PM UTC
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  erk Open/Closed:  Closed

( Jump to the original submission )

Mon 25 Jun 2007 09:24:48 PM UTC, comment #7: 

the C) issue was addressed (and solved) by patch
https://savannah.nongnu.org/patch/?6037
TSP now goes to /usr

I think we will rediscuss B) in another round.
I close this patch.

Eric NOULARD <erk>
Project Administrator
Wed 24 Jan 2007 08:42:20 PM UTC, comment #6: 

The attached file
tsp-rpm-5erk.patch
correspond to the modifications which effectively reached
the CVS for this pass.

This include A)

We should work on other patch set for B) and C).
This has been tested on FC6 i386.

(file #11855)

Eric NOULARD <erk>
Project Administrator
Wed 24 Jan 2007 06:24:25 PM UTC, comment #5: 

A) I understand the BuildRequires advantage.
We may keep it but handle it in a different way.
When you run CMake the tsp.spec is generated from tsp.spec.in.
The later may contain something like:

BuildRequires: cmake @LIBXML2_DEVEL@ @GTKX_DEVEL@ @FUSE_DEVEL@ ...

which are to be translated to NULL or convenient values
at cmake run time in the tsp.spec generated file.

When CMake runs it may further spit out
warning messages saying that missing
devel libs will narrow the TSP build.

You keep "optional" part optional but give developers
the precise knowledge of what they miss.

B) Making several TSP sub- or even separate-
package is indeed possible
and the best would be one for each "standalone" consumer
or provider, plus one tsp-core and one tsp-devel.
I think we may go for this in a second step
since many peoples here used to get all-in-one package.

C) Regarding /opt or /usr
we have choosen /opt to stick with LSB/FHS
http://refspecs.freestandards.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/execenvfhs.html
http://www.pathname.com/fhs/pub/fhs-2.3.html#OPTADDONAPPLICATIONSOFTWAREPACKAGES

Moreover this way it may even be installed in
/opt/tsp-x.y.z which enable multiple version handling
with update-alternatives(8).

I think I will go for fixing A and go for cvs commit
then we may discuss B) and C) afterwards.
I will file some examples for C).

Thank you for your contribution.

Eric NOULARD <erk>
Project Administrator
Wed 24 Jan 2007 05:47:39 PM UTC, comment #4: 

I have tried it and it works for me (FC6)
I agree that the build requires I put there are aggressive. The good thing is that it tells the person who builds it which packages are needed in an easy way.
On the other hand some of the executables are optional and the Cmake system can handle that fine.
Maybe we should split up the tsp packages into parts so that only the people who want certain clients can choose to install them (including all the dependencies).
I also feel that there should be a tsp-devel package with all the headers.
Furthermore the files should not be installed in /opt/tsp but in the usual places (/usr/bin, /usr/include, /usr/lib etc.)
Also the scripts should go in /usr/bin.

Robert de Vries <rhdv>
Project Member
Wed 24 Jan 2007 11:37:58 AM UTC, comment #3: 

Robert,

Would you try my modified patch?
It should be effective source dir  name independant.
Using make package_source to first build the source tarball
then go as you did (using CMake -E command mode when possible though).

I think we should get rid of some
BuildRequires: dependencies since most of
them are not REQUIRED but just inspected by Cmake
which may or may not compile part of TSP depending
on what is found.

I will make another try for improbing this.

(file #11834)

Eric NOULARD <erk>
Project Administrator
Wed 24 Jan 2007 08:26:34 AM UTC, comment #2: 

Hi Robert,

I'm currently testing this patch.
It almost works for me.
I need to some refinement because you may not
assume the name of the TSP source tree is
${PACKAGE_NAME}-${PACKAGE_VERSION}-Source
but deduce the real name from
${CMAKE_SOURCE_DIR}

I will make the change and post a modify patch.
Nevertheless thanks you again for this patch.

Eric NOULARD <erk>
Project Administrator
Mon 15 Jan 2007 08:43:54 PM UTC, comment #1: 

The new patch tsp-rpm-2.patch supersedes the previous patch (tsp_fix_rpm.patch).

Robert de Vries <rhdv>
Project Member
Mon 15 Jan 2007 12:58:49 PM UTC, original submission:  

This patch fixes the building of rpm and src.rpm packages using the cmake build system.
The patch is relative to version 0.8.2.

Robert de Vries <rhdv>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #11855:  tsp-rpm-5erk.patch added by erk (7KiB - text/x-patch)
file #11834:  tsp-rpm-4erk.patch added by erk (5KiB - text/x-patch - Use make package_source for tarball and cmake mode)
file #11762:  tsp-rpm-2.patch added by rhdv (5KiB - text/x-patch - Improved build requirements and fixed srpm build)
file #11758:  tsp_fix_rpm.patch added by rhdv (5KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by erk (Posted a comment)
  • -email is unavailable- added by rhdv (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

     

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-06-25 erk StatusReady For Test Done
        Open/ClosedOpen Closed
    2007-01-24 erk Attached File- Added tsp-rpm-5erk.patch, #11855
        StatusIn Progress Ready For Test
    2007-01-24 erk Assigned toNone erk
    2007-01-24 erk Attached File- Added tsp-rpm-4erk.patch, #11834
    2007-01-24 erk StatusNone In Progress
    2007-01-15 rhdv Attached File- Added tsp-rpm-2.patch, #11762
    2007-01-15 rhdv Attached File- Added tsp_fix_rpm.patch, #11758

    Back to the top


    Powered by Savane 3.9