mldonkey, a multi-networks file-sharing client - Patches: patch #6269, BT: choke bug
You are not allowed to post comments on this tracker with your current authentication level.
patch #6269: BT: choke bug
Submitter: | bogeyman <bogeyman> | ||
Submitted: | Fri 16 Nov 2007 01:15:43 PM UTC | ||
Category: | Bug fixes | Priority: | 7 - High |
Status: | Postponed | Assigned to: | None |
Open/Closed: | Open |
( Jump to the original submission )
Mon 07 Jan 2008 08:42:59 PM UTC, comment #10: |
Eike Haberland <eikeh> |
Thu 03 Jan 2008 05:13:13 PM UTC, comment #9: Works well for me ( bt-20071219.patch ).
|
Hire <hire> |
Wed 19 Dec 2007 11:46:18 AM UTC, comment #8: I append my actual patch, but this will need some more time and testing... Merry Christmas to all of you |
bogeyman <bogeyman>![]() |
Wed 05 Dec 2007 03:50:41 PM UTC, comment #7: Here are the results of my speed tests:
|
Eike Haberland <eikeh> |
Sun 02 Dec 2007 10:32:45 PM UTC, comment #6: With the latest patches applied my logfile was flooded by print_control messages once a minute (look at http://pastebin.org/10221). I got rid of them by commenting out the appropriate lines in bTClients.ml
|
Eike Haberland <eikeh> |
Sun 02 Dec 2007 07:51:12 PM UTC, comment #5: here the last version, with some verbosity fixes and it rises the client timeout from 90 to 130 sec (pings are send every 120 secs). the second patch removes a peer after three failed retries. Good clients that disconnects are not removed. Feel free to test |
bogeyman <bogeyman>![]() |
Fri 30 Nov 2007 04:45:22 PM UTC, comment #4: Working on a new patch, maybe including peer reconnects, coming soon ;) |
bogeyman <bogeyman>![]() |
Mon 19 Nov 2007 09:03:55 PM UTC, comment #3: My first impression is that I get more sources but there is only a slightly increased download speed. (E.g. with this patch a torrent was downloaded in 22m 38s and the unpatched 2.9.2.CVS needed 25m 28s)
|
Eike Haberland <eikeh> |
Sun 18 Nov 2007 02:07:42 PM UTC, comment #2: That only means the swarmer is gone, when you received the choke. Since you finished the download, that should be no problem?! So this message could be verbose... |
bogeyman <bogeyman>![]() |
Sun 18 Nov 2007 01:37:52 AM UTC, comment #1: download works for me, don't know if it's realy faster (it is fast)
|
orbit <orbit> |
Fri 16 Nov 2007 01:15:43 PM UTC, original submission:
After been choked, no blocks can be found, we send empty request packets and the peer will timeout and be dropped. CommonSwarming.clear_uploader_intervals should not be called directly, CommonSwarming.update_uploader_intervals in update_client_bitmap does the magic.
|
bogeyman <bogeyman>![]() |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 10 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2010-12-21 | spiralvoice | Status | Ready For Test | ![]() |
Postponed |
2007-12-19 | bogeyman | Attached File | - | ![]() |
Added bt-20071219.patch, #14663 |
2007-12-19 | bogeyman | Attached File | #14537 | ![]() |
Removed |
2007-12-19 | bogeyman | Attached File | #14536 | ![]() |
Removed |
2007-12-19 | bogeyman | Attached File | #14536 | ![]() |
Removed |
2007-12-02 | bogeyman | Attached File | - | ![]() |
Added bt-noblockfound6.patch, #14536 |
Attached File | - | ![]() |
Added bt-notremovingpeers5.patch, #14537 | ||
Status | None | ![]() |
Ready For Test | ||
2007-11-30 | bogeyman | Attached File | #14416 | ![]() |
Removed |
2007-11-16 | bogeyman | Attached File | - | ![]() |
Added bt-noblockfound.patch, #14416 |
bt-20071219.patch works well - but the computer has to be fast enough. With an AthlonXP-1800/256 MB RAM this is no problem. But on my P2-450/128 MB RAM the first version (bt-noblockfound.patch) is still the fastest one. The later patches seem to cause a higher cpu and memory consumption.