patchmldonkey, a multi-networks file-sharing client - Patches: patch #6599, Allow values lower than...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6599: Allow values lower than max_upload_slots for BT-max_bt_uploaders

Submitter:  Renato Alves <rjalves>
Submitted:  Mon 04 Aug 2008 07:30:04 PM UTC
   
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Fri 31 Oct 2008 12:03:00 AM UTC, comment #4: 

This patch has some bad code.

The bug #24706 is submited.

It has the fix for this one.

You can check it here:
https://savannah.nongnu.org/bugs/index.php?24706#attached

Maxim <makc666>
Mon 04 Aug 2008 07:33:18 PM UTC, comment #3: 

Committed 2008/08/04

spiralvoice <spiralvoice>
Group administrator
Mon 04 Aug 2008 07:30:04 PM UTC, comment #2: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #23517

Following are the information included in the original report:

[field #0]                  Item ID: 23517
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #8]                         : Unknown bugs Field Display Type
[field #9]                 Category: Bittorrent-Plugin
[field #10]             Submitted by: rjalves
[field #11]              Assigned to: None
[field #12]             Submitted on: Samstag 07.06.2008 um 17:31
[field #13]                  Summary: Can't change the option BT-max_bt_uploaders to a value lower than 5
[field #14]      Original Submission: BT-max_bt_uploaders defaults to 3 but this value cannot be defined.
5 is the minimum value that the field accepts. Even if defined manually in bittorrent.ini as 4 or lower, the option is overwritten to 5 as soon as mldonkey starts.

Given the fact that the global system default is 5 upload slots, having BT-max_bt_uploaders setup to 5 causes all the slots to be reserved for bittorrent.
This makes edonkey module not to upload while bittorrent upload requests are in queue.
What happens is that edonkey module receives requests and places them in queue, but they never start uploading because bittorrent somehow takes priority.
[field #16]               Item Group: Program malfunction
[field #17]                   Status: Ready For Test
[field #18]        Component Version: None
[field #19]         Operating System: Linux
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #31]         Percent Complete: 0%
[field #33]                  Release: 2.9.5
[field #34]                  Release: 2.9.5
[field #58]          Binaries Origin: Gentoo ebuild
[field #59]                 CPU type: Intel x86
[field #60]                      CPU: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Tue 29 Jul 2008 12:46:26 PM UTC, comment #1: 

Please test the attached patch

I changed the behaviour as follows:

If max_bt_uploaders is changed to a value smaller than one
or the a value higher than max_upload_slots, its set to
the default of max_bt_uploaders, which is three.

So you are allowed to change the value in a range from
1 to max_upload_slots.

(file #16207)

spiralvoice <spiralvoice>
Group administrator
Mon 04 Aug 2008 07:30:04 PM UTC, original submission:  

BT-max_bt_uploaders defaults to 3 but this value cannot be defined.
5 is the minimum value that the field accepts. Even if defined manually in bittorrent.ini as 4 or lower, the option is overwritten to 5 as soon as mldonkey starts.

Given the fact that the global system default is 5 upload slots, having BT-max_bt_uploaders setup to 5 causes all the slots to be reserved for bittorrent.
This makes edonkey module not to upload while bittorrent upload requests are in queue.
What happens is that edonkey module receives requests and places them in queue, but they never start uploading because bittorrent somehow takes priority.

Renato Alves <rjalves>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #16207:  bt_slots.patch added by spiralvoice (1KiB - application/force-download)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by makc666 (Posted a comment)
  • -email is unavailable- added by spiralvoice (Updated the item)
  • -email is unavailable- added by rjalves (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-08-04 spiralvoice StatusWorks For Me Done
        Open/ClosedOpen Closed
    2008-08-04 spiralvoice CategoryNone Bug fixes
        StatusNone Works For Me
        SummaryCan\'t change the option BT-max_bt_uploaders to a value lower than 5 Allow values lower than max_upload_slots for BT-max_bt_uploaders
    2008-08-04 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, bug #23517 mldonkey, a multi-networks file-sharing client, patch #6599

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code