patchWeeChat - Patches: patch #6916, cygwin patch

 
 

patch #6916: cygwin patch

Submitted by:  None
Submitted on:  Mon 14 Sep 2009 09:39:19 AM UTC  
 
Category:  compilation Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Sebastien Helleu <flashcode> Originator Email:  -email is unavailable-
Open/Closed:  Closed IRC nick:  Gu1ll4um3r0m41n

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 14 Sep 2009 10:00:31 AM UTC, comment #1:

Also, there is a problem in src/plugin/scripts/weechat-perl-api.c.
Every function is defined like this "static XS(function_name)",
XS being a macro returning -on cygwin-:
_declspec(dllexport) void functionName(pTHX CV* cv)

It seems that on windows, you can't export a static function, so every function definition trigger an error:
../../../../../weechat-git/src/plugins/scripts/perl/weechat-perl-api.c:69: error: external linkage required for symbol 'functionName' because of 'dllexport' attribute.

I fixed this by removing "static" on every fonction and it seems to work, but there is probably a reason why all those functions are declared as static so i didn't included that in my patch.
A dev should look into it.

Anonymous
Mon 14 Sep 2009 09:39:19 AM UTC, original submission:

Patch to allow weechat to be compiled on cygwin.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #18714:  cygwin.path added by None (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by flashcode (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-01-23 flashcode StatusNone => Done
        Assigned toNone => flashcode
        Open/ClosedOpen => Closed
    2009-09-14 flashcode Categoryother => compilation
        PrivacyPrivate => Public
    2009-09-14 None Attached File- => Added cygwin.path, #18714

    Back to the top


    Powered by Savane 3.4