patchWeeChat - Patches: patch #7459, Fix a problem with certificate...


patch #7459: Fix a problem with certificate verification.

Submitter:  None
Submitted:  Wed 09 Feb 2011 05:39:41 PM UTC
Category:  other Priority:  7 - High
Status:  Done Privacy:  Public
Assigned to:  flashcode Originator Email:  -email is unavailable-
Open/Closed:  Closed IRC nick:  Gu1
* Mandatory Fields

Add a New Comment Rich Markup

Mon 14 Feb 2011 11:21:27 PM UTC, comment #2: 

Here is another version of the patch that doesn't modify the API. It just adds another parameter to the gnutls_callback_t prototype that specify the mode (either "verify" or "set certificate").

(file #22689)

Wed 09 Feb 2011 05:46:07 PM UTC, comment #1: 

oh, and i forgot the POC:
$ openssl genrsa -out server.key 4096
$ openssl req -new -key server.key -out server.csr
$ openssl x509 -req -days 365 -in server.csr -signkey server.key -out server.crt
$ openssl dhparam -outform PEM -out dhparam.pem 4096
$ openssl s_server -cert server.crt -key server.key -dhparam dhparam.pem -accept 6697

then try to connect on -ssl and there will be no verification of the server certificate.
If we configure openssl to request a client certificate using s_server's '-verify' option, then weechat will check the certificate (and detect it as self-signed).

$ openssl s_server -cert server.crt -key server.key -dhparam dhparam.pem -accept 6697 -verify yes

Wed 09 Feb 2011 05:39:41 PM UTC, original submission:  

It might be possible to fix the problem without changing the API by calling the gnutls_cb (=irc_server_gnutls_callback) function twice, first to verify the server's certificate and then to set the client certificate ?



(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by flashcode (Updated the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.


    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-04-05 flashcode Open/ClosedOpen Closed
    2011-03-02 flashcode CategoryNone other
        StatusNone Done
        Assigned toNone flashcode
    2011-02-14 None Attached File- Added 0001-Fix-a-problem-with-certificate-verification-v2.patch, #22689
    2011-02-09 None Attached File- Added 0001-Fix-a-problem-with-certificate-verification.patch, #22636

    Back to the top

    Powered by Savane 3.13-ee12.
    Corresponding source code