patchBos Wars - Patches: patch #8125, Patch to fix bug 35623

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8125: Patch to fix bug 35623

Submitter:  James McCulloch <silnarm>
Submitted:  Tue 16 Jul 2013 12:53:47 AM UTC
   
 
Open/Closed:  Closed Status:  Done
Assigned to:  feb

Sat 22 Feb 2014 09:45:29 PM UTC, comment #2: 

Patch applied to the development version. As we can't guarantee compatibitility with saved games of previous versions, I replaced SlotUsage with your new SlotUsage2.

In addition, used LuaToNumber instead of lua_tointeger.

Thank you for this well written patch.

François Beerten <feb>
Group administrator
Tue 16 Jul 2013 12:32:16 PM UTC, comment #1: 

Works great. Thanks!

Iwan Gabovitch <qubodup>
Tue 16 Jul 2013 12:53:47 AM UTC, original submission:  

Fixes the savegame issue reported here,

https://savannah.nongnu.org/bugs/?35623

New saves put the slot usage tables in a wrapper table, and call SlotUsage2() rather than SlotUsage(). Old saves can therefore still be loaded (it's backward compatible) but no check or conversion is performed on the call to SlotUsage(), so old saves that can't be loaded due to this bug need to be converted 'by hand' (suggest providing a script) as follows,

'SlotUsage' needs to be changed to 'SlotUsage2'
a '{' needs to be inserted before the second arg
a '}' needs to be inserted after all args

James McCulloch <silnarm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #28590:  save_fix.patch added by silnarm (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by feb (Posted a comment)
  • -email is unavailable- added by qubodup (Posted a comment)
  • -email is unavailable- added by silnarm (Submitted the item)
  •  

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-02-22 feb Open/ClosedOpen Closed
        Assigned tojsalmon3 feb
    2014-02-22 feb StatusNone Done
        Assigned toNone jsalmon3
    2013-07-16 silnarm Attached File- Added save_fix.patch, #28590

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code