helpNormalize Audio - Support: sr #108845, Solved: wrong Level-calculation...

 
 

sr #108845: Solved: wrong Level-calculation when files with "zero Power" involved

Submitter:  Matthias Heintze <mheintze>
Submitted:  Sat 04 Jul 2015 09:51:57 PM UTC
 
Category:  None Priority:  5 - Normal
Severity:  3 - Normal Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Operating System:  GNU/Linux
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Sun 19 Jul 2015 10:17:48 AM UTC, comment #2: 

Hi Matthias,

you submitted the issue here and in the Debian bug tracker. I suggest we continue the discussion here.

Unfortunately, you do not describe the actual problem you are trying to solve. It might help if you provide a file that demonstrates the problem.

I believe there is a problem if two adjacent files with level < 0 are processed: the second is moved into the slot of the first, but "i" is still incremented, so the second one is never removed. Is that the problem you are facing?

Maybe it would be better to remove "i++" from the loop header and put it into the else branch. Chris: what do you think?

Joachim

Joachim Reichel <joachim_r>
Sun 19 Jul 2015 10:12:21 AM UTC, comment #1: 
Joachim Reichel <joachim_r>
Sat 04 Jul 2015 09:51:57 PM UTC, original submission:  

for me this patch solving the problem:

ardour3@nb-ardour:~/normalize/normalize-audio-0.7.7/src$ diff -Naur  normalize.c normalize_new.c

--- normalize.c 2015-07-04 23:13:08.261839368 +0200
+++ normalize_new.c     2015-07-04 23:02:34.806698224 +0200
@@ -475,6 +475,7 @@
                (nfiles - i) * sizeof(char *));
        memmove(progress_info.file_sizes + i, progress_info.file_sizes + i + 1,
                (nfiles - i) * sizeof(off_t));
+       i--;
       }
     }

Thank you for this Software!
sorry for my english.

Matthias

Matthias Heintze <mheintze>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by joachim_r (Posted a comment)
  • -email is unavailable- added by joachim_r (CC Debian package maintainer)
  • -email is unavailable- added by mheintze (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-07-19 joachim_r Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.10