mainSavannah Administration - Support: sr #109663, $sys_trackers_attachments_dir does...

 
 

sr #109663: $sys_trackers_attachments_dir does not respect $sys_appdatadir overrides in .savane.conf.php

Submitter:  Andrew Janke <apjanke>
Submitted:  Fri 29 Mar 2019 03:32:10 AM UTC
   
 
Category:  Savannah website Priority:  5 - Normal
Severity:  2 - Minor Status:  Wont Do
Privacy:  Public Assigned to:  ineiev
Operating System:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 29 Mar 2019 08:02:43 PM UTC, comment #2: 


> but do we want that?


I have no opinion here. I don't know the Savane file hierarchy well enough to know what's better.

Andrew Janke <apjanke>
Fri 29 Mar 2019 04:09:57 PM UTC, comment #1: 

Currently, .savane.conf.php modifies both variables; if this isn't intentional, it may as well be.

We could set $sys_trackers_attachments_dir after reading .savane.conf.php like


if (!isset($sys_trackers_attachments_dir))
  $sys_trackers_attachments_dir = $sys_appdatadir . '/trackers_attachments';


but do we want that?

Ineiev <ineiev>
Site Administrator
Fri 29 Mar 2019 03:32:10 AM UTC, original submission:  

$sys_trackers_attachments_dir is initialized like this in include/init.php:

```
$sys_trackers_attachments_dir = $sys_appdatadir . '/trackers_attachments';

```

But this is done before .savane.conf.php is read, so it doesn't pick up user overrides to $sys_appdatadir. Is this intentional? Is the user supposed to configure $sys_trackers_attachments_dir separately?

Andrew Janke <apjanke>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ineiev (Posted a comment)
  • -email is unavailable- added by apjanke (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-04-18 ineiev StatusIn Progress Wont Do
        Open/ClosedOpen Closed
    2019-03-29 ineiev StatusNone In Progress
        Assigned toNone ineiev

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code