mainSavannah Administration - Support: sr #110705, gnulib git hooks ignored

 
 

sr #110705: gnulib git hooks ignored

Submitter:  Karl Berry <karl>
Submitted:  Mon 29 Aug 2022 04:57:36 PM UTC
   
 
Category:  Source code repositories - developer access Priority:  5 - Normal
Severity:  3 - Normal Status:  Done
Privacy:  Public Assigned to:  rwp
Operating System:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 30 Aug 2022 12:07:54 AM UTC, comment #1: 

Hi Karl.  None of those appear on the server side of things.  I think
those are all on your client side.  Maybe.  Possibly.  I'll give that
a definite maybe!

root@vcs2:~# ll /srv/git/gnulib.git/hooks/
total 40
-rw-rw-r-- 1 root root  441 Nov 28  2006 applypatch-msg.sample
-rw-rw-r-- 1 root root  588 Nov 28  2006 commit-msg.sample
-rw-rw-r-- 1 root root  152 Nov 28  2006 post-commit.sample
lrwxrwxrwx 1 root root   36 Nov 29  2010 post-receive.orig -> /usr/local/bin/git-post-receive-hook
-rwxrwxr-x 1 root root  207 Nov 28  2006 post-update
-rw-rw-r-- 1 root root  388 Nov 28  2006 pre-applypatch.sample
-rw-rw-r-- 1 root root 1696 Nov 28  2006 pre-commit.sample
-rw-rw-r-- 1 root root 4262 Nov 28  2006 pre-rebase.sample
-rwxr-xr-x 1 root root 4799 Nov 27  2021 update

Therefore I think the pre-commit, commit-msg, post-commit, hooks must
be on your client side of things.  Especially if it happened during a
git-commit.  On the server side if a git-push.

I am thinking that you have upgraded your version of git recently and
now that newer version of git is working on your previously existing
sandbox working copy and a previous version of git created those files
as examples that were not execuable.  But now the newer version of git
complains about this.  Please check your local sandbox and let me know.

Honestly I find that behavior of git rather nasty.  Crass!  Course.
Unrefined.  Definitely less than nice by a lot!

Bob Proulx <rwp>
Site Administrator
Mon 29 Aug 2022 04:57:36 PM UTC, original submission:  

Committing to gnulib, I got several warnings:

hint: The '.git/hooks/pre-commit' hook was ignored because it's not set as executable.                                                                        
hint: You can disable this warning with `git config advice.ignoredHook false`. 
hint: The '.git/hooks/commit-msg' hook was ignored because it's not set as executable.                                                                        
hint: You can disable this warning with `git config advice.ignoredHook false`. 
hint: The '.git/hooks/post-commit' hook was ignored because it's not set as executable.                                                                       
hint: You can disable this warning with `git config advice.ignoredHook false`. 

Unfortunately I'm not sure when it started. A few days ago, maybe longer.

If the hooks aren't going to be executed, seems like they should be removed. Or fixed. Or something. Thanks.

Karl Berry <karl>
Site Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rwp (Posted a comment)
  • -email is unavailable- added by karl (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-08-30 rwp StatusNone Done
        Assigned toNone rwp
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code