taskWeeChat - Tasks: task #11965, Show nick only once for multiple...

 
 

task #11965: Show nick only once for multiple adjacent messages from same sender

Submitted by:  Marcin Kulik <sickill>
Submitted on:  Tue 27 Mar 2012 03:30:33 PM UTC  
 
Category:  display Should Start On:  Tue 27 Mar 2012 12:00:00 AM UTC
Should be Finished on:  Tue 27 Mar 2012 12:00:00 AM UTC Priority:  5 - Normal
Status:  Done Privacy:  Public
Percent Complete:  100% Assigned to:  Sebastien Helleu <flashcode>
Originator Name:  Open/Closed:  Closed
Planned Release:  0.3.8 IRC nick: 

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Tue 03 Apr 2012 09:12:51 PM UTC, comment #11:

Works great, thank you! Nicely done.

Marcin Kulik <sickill>
Tue 03 Apr 2012 07:43:33 PM UTC, comment #10:

Bugs fixed, and now replacement string uses nick color.

Warning: due to use of a new tag, the option will now act on new messages only (you can not hide prefix any more for messages displayed before your /upgrade, because old messages don't have this new tag).

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Mon 02 Apr 2012 12:30:02 PM UTC, comment #9:

Ok. This problem will be fixed soon, I found the problem (after /upgrade or sometimes the flag in lines for hiding this prefix is not reset, so in near future, I'll not cache value in lines any more, but compute it when displaying messages on screen).

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Mon 02 Apr 2012 12:26:10 PM UTC, comment #8:

I commented on the gist, stating which lines are wrong.

Marcin Kulik <sickill>
Mon 02 Apr 2012 12:20:10 PM UTC, comment #7:

Sorry for confusion, pasted text didn't wrap, here it is updated: https://gist.github.com/98e28f089ce342f54965

Marcin Kulik <sickill>
Mon 02 Apr 2012 11:17:31 AM UTC, comment #6:

Ah I missed the last line, where prefix is not hidden. I already saw such problems on my side, but was unable to reproduce, I'll check that.

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Mon 02 Apr 2012 11:15:09 AM UTC, comment #5:

What is wrong on your paste?

And btw another commit will follow soon, to fix prefix hidden on wrong messages (for example join/quit messages), and use nick color for string (when prefix is replaced by a string).

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Mon 02 Apr 2012 11:10:08 AM UTC, comment #4:

I have seen your commit yesterday and compiled latest version but it seems it's worse than it was before, see here: https://gist.github.com/98e28f089ce342f54965

Marcin Kulik <sickill>
Wed 28 Mar 2012 08:10:27 PM UTC, comment #3:

But, but.. there are 2 bugs:
- too many things hidden (for example the prefix of join/quit messages), it should never be hidden
- problem with filtered lines, the nick after a hidden message can be hidden too, which is a problem.
I'm working on these problems, they should be fixed quickly.

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Wed 28 Mar 2012 07:59:21 PM UTC, comment #2:

Awesome! Now that was fast. I just checked it and it works like a charm. Exactly like I thought it should work.

Marcin Kulik <sickill>
Wed 28 Mar 2012 04:15:19 PM UTC, comment #1:

Thank you for the great idea!

It is now done, you can test with:

/set weechat.look.prefix_same_nick " "

And you can use another string to display instead of empty prefix if you want, for example (with UTF-8 locale):

/set weechat.look.prefix_same_nick "…"

Sebastien Helleu <flashcode>
Project AdministratorIn charge of this item.
Tue 27 Mar 2012 03:30:33 PM UTC, original submission:

It would be really awesome to have an option to skip displaying  nick for second, third, fourth (etc) message by the same sender.

Right now if someone writes 5 messages I see 5 lines with the same prefix (nick). It would be much easier to read channel in this shape: https://gist.github.com/2216996

I could help with implementation.

Marcin Kulik <sickill>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by flashcode (Posted a comment)
  • -email is unavailable- added by mkaysi
  • -email is unavailable- added by sickill (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-06-03 flashcode Open/ClosedOpen => Closed
    2012-04-03 flashcode StatusIn Progress => Done
        Percent Complete90% => 100%
    2012-04-02 flashcode StatusDone => In Progress
        Percent Complete100% => 90%
    2012-03-28 flashcode StatusNone => Done
        Percent Complete0% => 100%
        Assigned toNone => flashcode
        Planned ReleaseNone => 0.3.8
    2012-03-27 mkaysi Carbon-Copy- => Added mkaysi

    Back to the top


    Powered by Savane 3.4