taskSavannah Administration - Tasks: task #15062, Submission of Guile-Git

 
 

task #15062: Submission of Guile-Git

Submitted by:  Erik Edrosa <orangeshark>
Submitted on:  Wed 10 Oct 2018 03:26:06 AM UTC  
 
Should Start On:  Wed 10 Oct 2018 12:00:00 AM UTC Should be Finished on:  Sat 20 Oct 2018 12:00:00 AM UTC
Category:  Project Approval Priority:  5 - Normal
Status:  Done Privacy:  Public
Percent Complete:  0% Assigned to:  Ineiev <ineiev>
Open/Closed:  Closed Effort:  0.00

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Wed 28 Nov 2018 06:25:10 PM UTC, comment #16: 

Thank you, approving.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Mon 26 Nov 2018 07:23:07 PM UTC, comment #15: 

I have attached a new tarball which adds the LGPL file and removed those problematic files from the archive.

(file #45531)

Erik Edrosa <orangeshark>
Mon 26 Nov 2018 05:49:09 AM UTC, comment #14: 

Yes, removing problematic files from the archive would be fine.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sun 25 Nov 2018 11:18:25 PM UTC, comment #13: 

I've been looking over the tests and I don't think it would be possible to generate the repositories as some of the tests require the data to remain the same. An alternative would be to remove those script files that are found in the archive. They are just samples and have no impact on the actual repository. Would this be fine?

Erik Edrosa <orangeshark>
Sun 11 Nov 2018 06:58:32 AM UTC, comment #12: 

I think generating repositories when the running tests would be the better option.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sat 10 Nov 2018 02:13:09 AM UTC, comment #11: 

Would it be possible to state in the README of tests/data that the files in those archives are under those notices unless the file states otherwise?

I guess the alternative would be to remove the archive files and just generate the git repositories before running the tests.

Erik Edrosa <orangeshark>
Sun 04 Nov 2018 10:31:09 AM UTC, comment #10: 

If there is no further interest, I'll cancel this submission.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Wed 24 Oct 2018 03:09:38 AM UTC, comment #9: 

> For m4/guile.m4, should I provide a copy of the license in the m4 directory or at the root of the project directory?


I think the convention is to put licenses in the topmost directory, https://www.gnu.org/prep/maintain/html_node/License-Notices.html

> The Git repository in tests/data/simple-bare.tgz was generated using this library, it should be the same as if it was generated with Git.


What notices for that archive should be? Some of the texts it contains are copyrighted by Junio Hamano, other lack any notices.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Mon 22 Oct 2018 08:10:30 PM UTC, comment #8: 

For m4/guile.m4, should I provide a copy of the license in the m4 directory or at the root of the project directory? I coped this file over from GNU Guile.

The Git repository in tests/data/simple-bare.tgz was generated using this library, it should be the same as if it was generated with Git.

Erik Edrosa <orangeshark>
Mon 22 Oct 2018 03:39:38 AM UTC, comment #7: 

There are still some minor issues.

  • m4/guile.m4 refers to the LGPL, however, no copy of that license

is provided.

  • it looks like tests/data/simple-bare.tgz includes some files from Git; if this is correct, the copyright and license notices in tests/data/README may be invalid.
Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sat 20 Oct 2018 02:37:27 AM UTC, comment #6: 

Hello Ineiev,

I have added the notices to tests/data files and configure.ac. There is a couple of other scripts that are less than ten lines that are trivial so do not have the notice.

For static/normalize.css I decided to just remove the file from the project. I might just remove the web portion of the project soon anyways.

(file #45249)

Erik Edrosa <orangeshark>
Fri 19 Oct 2018 04:15:34 AM UTC, comment #5: 

Hello, Erik;

On trivial files: for the purpose of copyright, the standards of nontriviality are rather low: files more than ten lines long are considered nontrivial.

If upstream doesn't want to add the notices to their files, you basically have two options: make sure to add them in your copy, and don't use those files at all.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Thu 18 Oct 2018 10:33:36 PM UTC, comment #4: 

Hello Ineiev,

My mistake with the tests/data files, I forgot about those. I thought configure.ac was trivial enough that it was not needed, but I can add notices to that file. There is also pre-inst-env.in and test-env.in that are also trivial, would they need notices as well?

Going through the files again, I noticed static/normalize.css does not have a copyright or license notice (just mentions MIT License). I decided to look upstream and someone already opened an issue about the lack of these notices for the files but they closed it saying these notices are not needed. I assume this might be an issue for this project's approval?

Erik Edrosa <orangeshark>
Wed 17 Oct 2018 04:11:48 PM UTC, comment #3: 

Did you attach the right file? Files like configure.ac and tests/data/simple.tgz still have no notices.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Tue 16 Oct 2018 04:11:04 PM UTC, comment #2: 

Here is a new tarball where I added valid copyright and license notices.

(file #45210)

Erik Edrosa <orangeshark>
Fri 12 Oct 2018 08:13:34 AM UTC, comment #1: 

Please make sure all files in your tarball have valid copyright and license notices.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Wed 10 Oct 2018 03:26:06 AM UTC, original submission:  

A new project has been registered at Savannah
This project account will remain inactive until a site admin approves
or discards the registration.

Registration Administration

While this item will be useful to track the registration process,
approving or discarding the registration must be done using the specific Group Administration page, accessible only to site administrators,
effectively logged as site administrators (superuser):

Registration Details

  • Name: Guile-Git
  • System Name:  guile-git
  • Type: non-GNU software and documentation
  • License: GNU General Public License v3 or later

Description:

Guile-Git is a GNU Guile library providing bindings to libgit2. The purpose of the project is to provide a way for GNU Guile users a way to access and manipulate git source control repositories programmatically. The goal of the project is to be a stepping to stone to create more advance software that uses git like integrating git into other software or creating a git hosting service. The project uses GNU Guile as the programming language.

Other Software Required:

libgit2, GPLv2 with linking exception, https://libgit2.org/
scheme-bytestructures, GPLv3+, https://github.com/TaylanUB/scheme-bytestructures
guile, LGPLv3+, https://www.gnu.org/software/guile/
texinfo, GPLv3+, https://www.gnu.org/software/texinfo/
autoconf, GPLv3+, http://www.gnu.org/software/autoconf/
automake, GPLv2+, https://www.gnu.org/software/automake/
pkg-config, GPLv2+, https://www.freedesktop.org/wiki/Software/pkg-config

Tarball URL:

https://gitlab.com/guile-git/guile-git/uploads/e8c218ac7ae77b745c44d1ffbe34f1dd/guile-git-0.1.0.tar.gz

Erik Edrosa <orangeshark>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #45531:  guile-git-0.1.1.tar.gz added by orangeshark (254KiB - application/gzip - new tarball with the COPYING.LESSER and git hook scripts removed)
file #45249:  guile-git-0.1.1.tar.gz added by orangeshark (265KiB - application/gzip)
file #45210:  guile-git-0.1.1.tar.gz added by orangeshark (267KiB - application/gzip - new tarball with copyright and license notices)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ineiev (Posted a comment)
  • -email is unavailable- added by orangeshark (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-11-28 ineiev StatusIn Progress => Done
        Open/ClosedOpen => Closed
    2018-11-26 orangeshark Attached File- => Added guile-git-0.1.1.tar.gz, #45531
    2018-10-20 orangeshark Attached File- => Added guile-git-0.1.1.tar.gz, #45249
    2018-10-16 orangeshark Attached File- => Added guile-git-0.1.1.tar.gz, #45210
    2018-10-12 ineiev StatusNone => In Progress
        Assigned toNone => ineiev

    Back to the top


    Powered by Savane 3.5