taskSavannah Administration - Tasks: task #15159, Submission of iMBR

 
 

task #15159: Submission of iMBR

Submitted by:  Alexei Malinin <alexei_malinin>
Submitted on:  Sat 19 Jan 2019 08:41:28 PM UTC  
 
Should Start On:  Fri 18 Jan 2019 09:00:00 PM UTC Should be Finished on:  Mon 28 Jan 2019 09:00:00 PM UTC
Category:  Project Approval Priority:  5 - Normal
Status:  Done Privacy:  Public
Percent Complete:  0% Assigned to:  Ineiev <ineiev>
Open/Closed:  Closed Effort:  0.00

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Fri 25 Jan 2019 06:24:39 AM UTC, comment #19: 

Thank you, approving.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Thu 24 Jan 2019 07:56:09 PM UTC, comment #18: 

My examples were too old. It was my mistake, sorry. Please review the attached tarball.

(file #46091)

Alexei Malinin <alexei_malinin>
Thu 24 Jan 2019 06:26:53 PM UTC, comment #17: 

Fair enough.

What about NEWS and INSTALL?

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Thu 24 Jan 2019 06:05:28 PM UTC, comment #16: 

"Valid copyright notices" document
(https://savannah.gnu.org/maintenance/ValidNotices/)
says: "For copyright purpose, any file more than ten lines long
is nontrivial, so it should have copyright and license notices."

I think that binary files in the catalog ./tests/data
do not need notices because:
(1) the text files with pattern "*.fdisk" are trivial
    (i. e. NOT "more than ten lines long") files,
    so they are NOT copyrightable files;
(2) the other files are binary equivalents of the above
    text files so they are also trivial and NOT copyrightable.

PS. Semantically, all files in the catalog ./tests/data are
    examples of hard disk MBR partition table derived from
    OpenBSD fdisk utility.

Alexei Malinin <alexei_malinin>
Thu 24 Jan 2019 04:50:53 PM UTC, comment #15: 

So you think that this tarball is compliant.

Probably the ValidNotices page isn't written clearly enough.

Let us start with the binary files: do you think they need notices or not? Could you provide a quotation from ValidNotices (or any page it refers to) that supports your conclusion?

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Thu 24 Jan 2019 09:30:56 AM UTC, comment #14: 

I am afraid I do not understand you. All nontrivial files (except binary) have valid copyright and license notices (see the attached tarball). I have implemented all the requirements of https://savannah.gnu.org/maintenance/ValidNotices/.

It is my first project for Savannah so it hard for me to meet all necessary requirements but I try hard.

Please write what else needs to be fixed.

--
Alexei

(file #46088)

Alexei Malinin <alexei_malinin>
Thu 24 Jan 2019 07:18:38 AM UTC, comment #13: 

I believe it would be hard for you to follow Savannah requirements.  You don't think of them as of something necessary to do.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Wed 23 Jan 2019 11:32:36 AM UTC, comment #12: 

Hello, Ineiev.

What should I do next?

--
Alexei

Alexei Malinin <alexei_malinin>
Mon 21 Jan 2019 07:49:20 PM UTC, comment #11: 

I've read this page https://savannah.gnu.org/maintenance/ValidNotices/.

All files in my distribution have valid copyright and license notices except:
- binary files in the catalog ./tests/data;
- text files (which, in my opinion, should not contain copyright and license notices) in the catalog ./.:
  - AUTHORS,
  - INSTALL,
  - NEWS,
  - README.

It was strange for me that makefiles should also contain copyright and license notices (for example, makefiles in OpenBSD OS do not contain such notices), but... it's your rules.

--
Alexei

Alexei Malinin <alexei_malinin>
Mon 21 Jan 2019 03:43:47 PM UTC, comment #10: 

Thank you!

Please check all files, as in "find . -type f".  All nontrivial files should have valid copyright and license notices.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Mon 21 Jan 2019 08:52:42 AM UTC, comment #9: 

OK. New tarball is attached.

(file #46055)

Alexei Malinin <alexei_malinin>
Mon 21 Jan 2019 04:37:02 AM UTC, comment #8: 

For example: makefile is copyrightable, but lacks both copyright and license notices.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sun 20 Jan 2019 06:41:27 PM UTC, comment #7: 

Could you explain by example?

--
Alexei

Alexei Malinin <alexei_malinin>
Sun 20 Jan 2019 06:25:42 PM UTC, comment #6: 

I'm afraid you either haven't read the page I linked to in my previous comment or haven't looked through all files in your tarball.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sun 20 Jan 2019 06:23:25 PM UTC, comment #5: 

All copyrightable files have valid copyright and license notices.

For example:

/* OS.c, v. 1.6, 2018-01-28 */
/* OS.c, v. 1.5, 2018-01-10 */
/* OS.c, v. 1.4, 2017-11-06 */

/*

  • Copyright (c) 1997-2018 Alexei G. Malinin <Alexei.Malinin@mail.ru>

*

  • Permission to use, copy, modify, and distribute this software for any
  • purpose with or without fee is hereby granted, provided that the above
  • copyright notice and this permission notice appear in all copies.

*

  • THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
  • WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
  • MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
  • ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
  • WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
  • ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
  • OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.

*/

--
Alexei

Alexei Malinin <alexei_malinin>
Sun 20 Jan 2019 06:12:37 PM UTC, comment #4: 

Thank you!

The next point would be adding valid copyright and license notices to all copyrightable files in your tarball.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sun 20 Jan 2019 05:29:13 PM UTC, comment #3: 

Thanks for the review.

Sorry for the wrong patch in the previous comment. Correct patch follows.

--
Alexei

diff -dur iMBR-1.6/INSTALL iMBR-1.7/INSTALL
--- iMBR-1.6/INSTALL    2017-12-26 20:43:04.000000000 +0300
+++ iMBR-1.7/INSTALL    2019-01-20 20:01:34.000000000 +0300
@@ -1,7 +1,7 @@
 In the very beginning iMBR was developed in MS-DOS v6.22 with Watcom C compiler
 and assembler. Nowadays the primary development platform for iMBR is OpenBSD.
-Also NetBSD and Linux are supported. iMBR for Windows can be prepared on the
-above development platforms.
+Also NetBSD and GNU/Linux are supported. iMBR for Windows can be prepared on
+the above development platforms.

 Required software
@@ -18,7 +18,7 @@
 Building
 --------

-To build iMBR on OpenBSD/NetBSD/Linux:
+To build iMBR on OpenBSD, NetBSD, GNU/Linux:
 1) unzip and untar the distribution iMBR-x.y.tgz source tarball:
        $ tar -zxvf iMBR-x.y.tgz
        $ cd iMBR-x.y
@@ -37,8 +37,8 @@
 Testing
 -------

-For testing (only for OpenBSD/NetBSD/Linux) purposes some programs and scripts
-were developed:
+For testing (only for OpenBSD, NetBSD, GNU/Linux) purposes some programs
+and scripts were developed:
 - minimal PBR, which prints the CPU registers and flags values, and the
   partition number, the PBR has been booted from;
 - MBR/PBR installer for real disks and disk images;
@@ -53,7 +53,8 @@
 Installing
 ----------

-To install iMBR on OpenBSD/NetBSD/Linux (root privileges may be required):
+To install iMBR on OpenBSD, NetBSD, GNU/Linux (root privileges may be
+required):
 8) run the top level makefile:
        # make DESTDIR=dir0/ prefix=dir install
    for example:
diff -dur iMBR-1.6/NEWS iMBR-1.7/NEWS
--- iMBR-1.6/NEWS       2018-01-29 18:28:05.000000000 +0300
+++ iMBR-1.7/NEWS       2019-01-20 20:03:03.000000000 +0300
@@ -1,3 +1,7 @@
+iMBR-1.7 (January 20, 2019):
+- documentation changes to meet criteria of Savannah
+  (https://savannah.nongnu.org/) have been applied
+
 iMBR-1.6 (January 29, 2018):
 - copyright license from
   https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/share/misc/license.template?rev=HEAD
@@ -11,7 +15,7 @@
 - compatibility with traditional MBRs
 - LBA support
 - manual pages
-- iMBR_editor can run on OpenBSD, NetBSD, Linux, Windows
+- iMBR_editor can run on OpenBSD, NetBSD, GNU/Linux, Windows

 iMBR-1.3 (August 05, 1997):
 - the first release for MS-DOS v6.22
diff -dur iMBR-1.6/README iMBR-1.7/README
--- iMBR-1.6/README     2018-01-27 23:51:04.000000000 +0300
+++ iMBR-1.7/README     2019-01-20 19:52:58.000000000 +0300
@@ -2,6 +2,6 @@
 programs supplied by other operating systems. iMBR can be configured (with
 iMBR_editor) so as it will present the user with a prompt, allowing a choice
 between partitions to boot from. Also iMBR preserves NT disk signature.
-iMBR_editor can run on OpenBSD, NetBSD, Linux, Windows.
+iMBR_editor can run on OpenBSD, NetBSD, GNU/Linux, Windows.

diff -dur iMBR-1.6/doc/iMBR_editor.mdoc iMBR-1.7/doc/iMBR_editor.mdoc
--- iMBR-1.6/doc/iMBR_editor.mdoc       2018-01-28 00:14:04.000000000 +0300
+++ iMBR-1.7/doc/iMBR_editor.mdoc       2019-01-20 19:58:33.000000000 +0300
@@ -229,7 +229,7 @@
 .Pp
 To install and configure the
 .Xr iMBR 8
-bootcode on Linux
+bootcode on GNU/Linux
 .Pq tested on Debian GNU/Linux-amd64, v9.3
 with boot disk
 .Sq sda
@@ -310,7 +310,7 @@
 .Ns .
 .Pp
 To install previously prepared MBR
-.Po on Linux, boot disk So sda Sc Pc
+.Po on GNU/Linux, boot disk So sda Sc Pc
 with
 .Xr iMBR 8
 options from the file
@@ -376,7 +376,7 @@
 events.
 .Pp
 There are operating systems which do not use PBR for booting
-.Po for example, some Linux distributions with
+.Po for example, some GNU/Linux distributions with
 .Qq GRUB
 installed as MBR
 .Pc
@@ -388,8 +388,8 @@
 .Em empty
 PBR with the MBR installed by this operating system, and then install and use
 .Xr iMBR 8
-.Ns . For the above example, if the installed Linux operating system has the
-root filesystem in the first primary partition of the boot disk
+.Ns . For the above example, if the installed GNU/Linux operating system has
+the root filesystem in the first primary partition of the boot disk
 .Sq hda
 and uses
 .Qq GRUB
@@ -398,7 +398,7 @@
 .Em empty
 .Ns !
 .Pc
-.Ns , then the following Linux command will replace the
+.Ns , then the following GNU/Linux command will replace the
 .Em empty
 PBR with the original MBR:
 .Bd -literal -offset Ds
diff -dur iMBR-1.6/makefile iMBR-1.7/makefile
--- iMBR-1.6/makefile   2018-01-29 18:28:19.000000000 +0300
+++ iMBR-1.7/makefile   2019-01-20 19:51:08.000000000 +0300
@@ -35,7 +35,7 @@
 AWK:=          awk

 PACKAGE:=      iMBR
-VERSION:=      1.6
+VERSION:=      1.7
 DIST:=         ${PACKAGE}-${VERSION}

 #DESTDIR:=     ${OUT_DIR}

Alexei Malinin <alexei_malinin>
Sun 20 Jan 2019 05:14:52 PM UTC, comment #2: 

Hello.

Will the following patch be enough?

--
Alexei

diff -du iMBR-1.6/INSTALL iMBR-1.7/INSTALL
--- iMBR-1.6/INSTALL    2017-12-26 20:43:04.000000000 +0300
+++ iMBR-1.7/INSTALL    2019-01-20 20:01:34.000000000 +0300
@@ -1,7 +1,7 @@
 In the very beginning iMBR was developed in MS-DOS v6.22 with Watcom C compiler
 and assembler. Nowadays the primary development platform for iMBR is OpenBSD.
-Also NetBSD and Linux are supported. iMBR for Windows can be prepared on the
-above development platforms.
+Also NetBSD and GNU/Linux are supported. iMBR for Windows can be prepared on
+the above development platforms.

 Required software
@@ -18,7 +18,7 @@
 Building
 --------

-To build iMBR on OpenBSD/NetBSD/Linux:
+To build iMBR on OpenBSD, NetBSD, GNU/Linux:
 1) unzip and untar the distribution iMBR-x.y.tgz source tarball:
        $ tar -zxvf iMBR-x.y.tgz
        $ cd iMBR-x.y
@@ -37,8 +37,8 @@
 Testing
 -------

-For testing (only for OpenBSD/NetBSD/Linux) purposes some programs and scripts
-were developed:
+For testing (only for OpenBSD, NetBSD, GNU/Linux) purposes some programs
+and scripts were developed:
 - minimal PBR, which prints the CPU registers and flags values, and the
   partition number, the PBR has been booted from;
 - MBR/PBR installer for real disks and disk images;
@@ -53,7 +53,8 @@
 Installing
 ----------

-To install iMBR on OpenBSD/NetBSD/Linux (root privileges may be required):
+To install iMBR on OpenBSD, NetBSD, GNU/Linux (root privileges may be
+required):
 8) run the top level makefile:
        # make DESTDIR=dir0/ prefix=dir install
    for example:
diff -du iMBR-1.6/NEWS iMBR-1.7/NEWS
--- iMBR-1.6/NEWS       2018-01-29 18:28:05.000000000 +0300
+++ iMBR-1.7/NEWS       2019-01-20 20:03:03.000000000 +0300
@@ -1,3 +1,7 @@
+iMBR-1.7 (January 20, 2019):
+- documentation changes to meet criteria of Savannah
+  (https://savannah.nongnu.org/) have been applied
+
 iMBR-1.6 (January 29, 2018):
 - copyright license from
   https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/share/misc/license.template?rev=HEAD
@@ -11,7 +15,7 @@
 - compatibility with traditional MBRs
 - LBA support
 - manual pages
-- iMBR_editor can run on OpenBSD, NetBSD, Linux, Windows
+- iMBR_editor can run on OpenBSD, NetBSD, GNU/Linux, Windows

 iMBR-1.3 (August 05, 1997):
 - the first release for MS-DOS v6.22
diff -du iMBR-1.6/README iMBR-1.7/README
--- iMBR-1.6/README     2018-01-27 23:51:04.000000000 +0300
+++ iMBR-1.7/README     2019-01-20 19:52:58.000000000 +0300
@@ -2,6 +2,6 @@
 programs supplied by other operating systems. iMBR can be configured (with
 iMBR_editor) so as it will present the user with a prompt, allowing a choice
 between partitions to boot from. Also iMBR preserves NT disk signature.
-iMBR_editor can run on OpenBSD, NetBSD, Linux, Windows.
+iMBR_editor can run on OpenBSD, NetBSD, GNU/Linux, Windows.

diff -du iMBR-1.6/makefile iMBR-1.7/makefile
--- iMBR-1.6/makefile   2018-01-29 18:28:19.000000000 +0300
+++ iMBR-1.7/makefile   2019-01-20 19:51:08.000000000 +0300
@@ -35,7 +35,7 @@
 AWK:=          awk

 PACKAGE:=      iMBR
-VERSION:=      1.6
+VERSION:=      1.7
 DIST:=         ${PACKAGE}-${VERSION}

 #DESTDIR:=     ${OUT_DIR}

Alexei Malinin <alexei_malinin>
Sun 20 Jan 2019 12:45:12 PM UTC, comment #1: 

Hello, Alexei!

Savannah is the forge for the GNU Project.  If your package is going to use Savannah for hosting, it should give our work due credit by calling our operating system GNU/Linux rather than Linux.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sat 19 Jan 2019 08:41:28 PM UTC, original submission:  

A new project has been registered at Savannah
This project account will remain inactive until a site admin approves
or discards the registration.

Registration Administration

While this item will be useful to track the registration process,
approving or discarding the registration must be done using the specific Group Administration page, accessible only to site administrators,
effectively logged as site administrators (superuser):

Registration Details


Description:

iMBR is an interactive bootcode program which is compatible with MBR bootcode programs supplied by other operating systems

FEATURES:
- iMBR can be configured (with iMBR_editor) so as it will present the user with a prompt, allowing a choice between partitions to boot from
- iMBR preserves Windows NT disk signature
- iMBR_editor can run on OpenBSD, NetBSD, Linux, Windows

Developed with:
- GNU assembler
- GNU C
- [GNU] make
- mandoc
- standard UNIX utilities
- Minimalist GNU for Windows (MinGW)

Other Comments:

this project web page - http://am1225.narod.ru/software/iMBR/

Tarball URL:

http://am1225.narod.ru/software/iMBR/iMBR-1.6.tgz

Alexei Malinin <alexei_malinin>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46091:  iMBR-1.7.tgz added by alexei_malinin (26KiB - application/octet-stream)
file #46088:  iMBR-1.7.tgz added by alexei_malinin (26KiB - application/octet-stream)
file #46055:  iMBR-1.7.tgz added by alexei_malinin (26KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ineiev (Posted a comment)
  • -email is unavailable- added by alexei_malinin (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-01-25 ineiev StatusIn Progress => Done
        Open/ClosedOpen => Closed
    2019-01-24 alexei_malinin Attached File- => Added iMBR-1.7.tgz, #46091
    2019-01-24 alexei_malinin Attached File- => Added iMBR-1.7.tgz, #46088
    2019-01-21 alexei_malinin Attached File- => Added iMBR-1.7.tgz, #46055
    2019-01-20 ineiev StatusNone => In Progress
        Assigned toNone => ineiev

    Back to the top


    Powered by Savane 3.5