taskSavannah Administration - Tasks: task #15228, Submission of Haed

 
 

task #15228: Submission of Haed

Submitted by:  Florian Evaldsson <caf2>
Submitted on:  Sun 31 Mar 2019 05:04:01 PM UTC  
 
Should Start On:  Sun 31 Mar 2019 12:00:00 AM UTC Should be Finished on:  Wed 10 Apr 2019 12:00:00 AM UTC
Category:  Project Approval Priority:  5 - Normal
Status:  Done Privacy:  Public
Percent Complete:  0% Assigned to:  Ineiev <ineiev>
Open/Closed:  Closed Effort:  0.00

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Tue 07 May 2019 08:36:02 AM UTC, comment #21: 

Thank you, approving.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sat 04 May 2019 05:45:33 PM UTC, comment #20: 

Ok, it seems like i missed the include files.

I used this command to look them through:
for file in $(find . -type f -regex '.*'); do echo $file $(grep -cri 'florian' $file); done | grep 0

I think it looks fine now?

> The time wasn't very long.

There have been longer ones?

(file #46865)

Florian Evaldsson <caf2>
Tue 30 Apr 2019 04:55:02 PM UTC, comment #19: 

The time wasn't very long.

You just should check every file, one by one, and make sure that all copyrightable files have these notices.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Mon 29 Apr 2019 04:18:18 PM UTC, comment #18: 

I have tried my best to make sure that everything is polished enough for a release, but unfortunately it seems like i missed some files. Maybe because the project is a bit larger than what im used to.

I hope i managed to get everything right in the latest release. Im sorry if this submission is taking much longer than what i think we both thought at the start.

Florian Evaldsson <caf2>
Thu 25 Apr 2019 07:57:26 AM UTC, comment #17: 

Have you checked literally all files in your tarball?

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Thu 25 Apr 2019 12:20:20 AM UTC, comment #16: 

Thx,

Fixed that and some other minior things.

See attached file

(file #46829)

Florian Evaldsson <caf2>
Tue 23 Apr 2019 08:41:28 AM UTC, comment #15: 

Files like

include/blibc/doc/doxygen_conf
include/blibc/test/test.c

still have no valid copyright and license notices.

Please check other files as well.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sun 21 Apr 2019 05:31:36 PM UTC, comment #14: 

I think i fixed it now

See attachment

(file #46807)

Florian Evaldsson <caf2>
Thu 18 Apr 2019 09:15:53 AM UTC, comment #13: 

> Should i put the full GPLv3 notice instead of the smaller variant i currently have at the bottom?


Yes, please do.

> Should i also include a LICENSE file with the full gpl text?


One copy per tarball is sufficient.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Tue 16 Apr 2019 09:41:52 AM UTC, comment #12: 

Hi

Should i put the full GPLv3 notice instead of the smaller variant i currently have at the bottom?
Should i also include a LICENSE file with the full gpl text?

Florian Evaldsson <caf2>
Mon 15 Apr 2019 09:20:49 AM UTC, comment #11: 

Thank you!

gui/images/README has no valid copyright notices, and the license notice doesn't look like recommended in https://www.gnu.org/licenses/gpl-howto.html.

> I dont feel like it looks like example folder containing example source files and license files etc. I think that would be useful.


Thank you, I'll think about it.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sun 14 Apr 2019 09:44:46 PM UTC, comment #10: 

I have attached an update trying to resolve the problem.
I looked into the emacs source, and found an example there. I changed the license files to readme files. I think that should solve the issue?

>  Yes, it does: https://savannah.gnu.org/maintenance/HowToGetYourProjectApprovedQuickly/. The registration page directed you to it.


I dont feel like it looks like example folder containing example source files and license files etc. I think that would be useful.

(file #46772)

Florian Evaldsson <caf2>
Sun 14 Apr 2019 07:42:39 AM UTC, comment #9: 

Images in gui/images/event_editor/ lack valid copyright and license notices; it looks like you confused copyright and license notices with license text. Can you tell the difference between those three things?

> I think it would be cool with a simple "how it should look like project with pseudo-code" that helps with understanding how things should look like. Maybe it exists already?


Yes, it does: https://savannah.gnu.org/maintenance/HowToGetYourProjectApprovedQuickly/. The registration page directed you to it.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Thu 11 Apr 2019 10:16:34 PM UTC, comment #8: 

Now i have added a license file to all images, and added a license file to all subprojects. Anything missing?

(file #46753)

Florian Evaldsson <caf2>
Thu 11 Apr 2019 07:16:42 AM UTC, comment #7: 

Ah ok,

> If there is no further interest, I'll cancel this submission.


Sorry, my fault. Had to do other things for some time

So i should put a LICENSE file in all folders of the smaller libraries?

>  We did have some tool, but it hasn't grown up from the beta stage. These days we check the tarballs manually.


Thats sad, such tool would be good to have

> This is a valid point, but I have no idea how we could keep our policies in effect without relying on package admins remembering them.


I think it would be cool with a simple "how it should look like project with pseudo-code" that helps with understanding how things should look like. Maybe it exists already?

Florian Evaldsson <caf2>
Wed 10 Apr 2019 05:00:34 PM UTC, comment #6: 

If there is no further interest, I'll cancel this submission.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Wed 03 Apr 2019 08:00:27 AM UTC, comment #5: 

Thank you!

> Just curious, do you use some tool to verify the license headers or just use some fancy regex grep?


We did have some tool, but it hasn't grown up from the beta stage. These days we check the tarballs manually.

Basically, all non-trivial files should have valid copyright and license notices, including images: when file format doesn't allow such embedded notices, a README file in the same directory should list these files and provide the notices for them.

> It was quite some time since i published my previous package, so i tend to forget all the procedures...


This is a valid point, but I have no idea how we could keep our policies in effect without relying on package admins remembering them.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Tue 02 Apr 2019 10:17:54 PM UTC, comment #4: 

It was quite some time since i published my previous package, so i tend to forget all the procedures... Just curious, do you use some tool to verify the license headers or just use some fancy regex grep?

Haed is something i have been working on since i started to learn programming like 8 years ago so, i ""blame"" that if there is some quality "issues"

I did improve the readme.md hopefully and some other license code misses. Now the full GPLv3 license is with this "release".

(file #46701)

Florian Evaldsson <caf2>
Tue 02 Apr 2019 04:48:37 AM UTC, comment #3: 

What versions of the GPL your package uses? (In any case, please include an exact copy of the GPL from gnu.org; don't modify it.)

Then, Savannah is the software forge of the GNU Project; when using our hosting facilities, packages should give our work due credit and call the operating system "GNU/Linux" rather than "Linux".

Also, please make sure that all copyrightable files in your package have valid copyright and license notices: files like readme.md and gui/src/dialog/draw/haed_dialog_animation_editor.c don't.

This is not your first Savannah package, you should already be familiar with such things.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Mon 01 Apr 2019 08:55:08 PM UTC, comment #2: 

I guess when it comes to code quality (very much alpha or beta version), and from the GNU coding standards it might be true that it does not follow them. So i guess i might kindly ask to leave it as non-GNU for now.

Florian Evaldsson <caf2>
Mon 01 Apr 2019 05:35:12 AM UTC, comment #1: 

Do you mean to offer your package to GNU?

If yes, you should follow a different procedure, outlined in https://www.gnu.org/help/evaluation.html.

Ineiev <ineiev>
Site AdministratorIn charge of this item.
Sun 31 Mar 2019 05:04:01 PM UTC, original submission:  

A new project has been registered at Savannah
This project account will remain inactive until a site admin approves
or discards the registration.

Registration Administration

While this item will be useful to track the registration process,
approving or discarding the registration must be done using the specific Group Administration page, accessible only to site administrators,
effectively logged as site administrators (superuser):

Registration Details

  • Name: Haed
  • System Name:  haed
  • Type: Official GNU software
  • License: GNU General Public License v2 or later (Other misc libraries are licensed with expat or similar.)

Description:

A game and program maker tool.
It also generates C code for the game

Other Software Required:

libeksparent - savannah

Tarball URL:

https://savannah.gnu.org/submissions_uploads/haed_first_release.tar.xz

Florian Evaldsson <caf2>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46865:  haed_first_release-7.tar.xz added by caf2 (155KiB - application/x-xz)
file #46829:  haed_first_release-6.tar.xz added by caf2 (156KiB - application/x-xz)
file #46807:  haed_first_release-5.tar.xz added by caf2 (169KiB - application/x-xz)
file #46772:  haed_first_release-4.tar.xz added by caf2 (169KiB - application/x-xz)
file #46753:  haed_first_release-3.tar.xz added by caf2 (169KiB - application/x-xz)
file #46701:  haed_first_release-2.tar.xz added by caf2 (168KiB - application/x-xz - Fixes to the first release)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ineiev (Posted a comment)
  • -email is unavailable- added by caf2 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-05-07 ineiev StatusIn Progress => Done
        Open/ClosedOpen => Closed
    2019-05-04 caf2 Attached File- => Added haed_first_release-7.tar.xz, #46865
    2019-04-25 caf2 Attached File- => Added haed_first_release-6.tar.xz, #46829
    2019-04-21 caf2 Attached File- => Added haed_first_release-5.tar.xz, #46807
    2019-04-14 caf2 Attached File- => Added haed_first_release-4.tar.xz, #46772
    2019-04-11 caf2 Attached File- => Added haed_first_release-3.tar.xz, #46753
    2019-04-02 caf2 Attached File- => Added haed_first_release-2.tar.xz, #46701
    2019-04-01 ineiev StatusNone => In Progress
        Assigned toNone => ineiev

    Back to the top


    Powered by Savane 3.5